You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/01 05:30:36 UTC
[GitHub] [skywalking-java] xjs1919 opened a new pull request, #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
xjs1919 opened a new pull request, #266:
URL: https://github.com/apache/skywalking-java/pull/266
### trace-ignore-plugin can also ignore LocalSpan and ExitSpan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #266:
URL: https://github.com/apache/skywalking-java/pull/266#issuecomment-1171990671
You could remove relative plugin, or change source codes.
This is not just concept conflict, also cause unpredictable bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xjs1919 commented on pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
xjs1919 commented on PR #266:
URL: https://github.com/apache/skywalking-java/pull/266#issuecomment-1171987775
how can i ignore the local span and the exit span？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
URL: https://github.com/apache/skywalking-java/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xjs1919 commented on pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
xjs1919 commented on PR #266:
URL: https://github.com/apache/skywalking-java/pull/266#issuecomment-1171995489
”remove relative plugin" can not satisfy this kind of situation：
i want to see the detailed trace spans only when occurs an error in production environment，when there is no error，i just want to ignore these spans。 skywalking provides dynamic configurations， when combined with the dynamic configuration， i can resolve this situation。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #266:
URL: https://github.com/apache/skywalking-java/pull/266#issuecomment-1171982317
Sorry, this is not what sampling means in SkyWalking. Also, this causes half noop span included in trace, which also breaks a trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #266: trace-ignore-plugin can also ignore LocalSpan and ExitSpan
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #266:
URL: https://github.com/apache/skywalking-java/pull/266#issuecomment-1172028925
You can do what you feel right. You have source codes, don't need our permission.
The review is from upstream perspective, we are clear sampling focuses on segment, not span, very clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org