[GitHub] [inlong] pocozh opened a new pull request, #5252: [INLONG-5251][SDK] DataProxy SDK(cpp) proxy client config and proxylist manager

[GitBox <gi...@apache.org>]

pocozh opened a new pull request, #5252:
URL: https://github.com/apache/inlong/pull/5252

   
   ### Prepare a Pull Request
   *(Change the title refer to the following example)*
   
   - [INLONG-5251][SDK] DataProxy SDK(cpp) proxy client config and proxylist manager
   
   *(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
   
   - Fixes #5251 
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
     *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #5252: [INLONG-5251][SDK] Add proxy client config and proxylist manager for DataProxy C++ SDK

[GitBox <gi...@apache.org>]

dockerzhang merged PR #5252:
URL: https://github.com/apache/inlong/pull/5252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] EMsnap commented on a diff in pull request #5252: [INLONG-5251][SDK] DataProxy SDK(cpp) proxy client config and proxylist manager

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #5252:
URL: https://github.com/apache/inlong/pull/5252#discussion_r933059756


##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-cpp/src/base/client_config.h:
##########
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef DATAPROXY_SDK_BASE_CLIENT_CONFIG_H_
+#define DATAPROXY_SDK_BASE_CLIENT_CONFIG_H_
+
+#include <stdint.h>
+#include <string>
+#include <vector>
+
+namespace dataproxy_sdk
+{
+  class ClientConfig
+  {
+  private:
+    std::string config_path_;
+    bool user_config_err_=false;
+    int32_t buf_num_; //sendbuf num of each bufpool, max_buf_pool_/(ext_pack_size_+400)
+
+  public:
+    //new parameters
+    int32_t thread_nums_;           //network thread nums
+    int32_t shared_buf_nums_; //bufpool nums in shared method // TODO: 取消给参数，用buffer_num_per_groupId替换

Review Comment:
   chinese character



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org