You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/05/12 13:04:55 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #26630: [Tour of Beam] [Frontend] Unit navigation

damccorm commented on code in PR #26630:
URL: https://github.com/apache/beam/pull/26630#discussion_r1192343270


##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -48,8 +48,9 @@ void main() {
       await _checkContentTreeBuildsProperly(wt);
       await _checkContentTreeScrollsProperly(wt);
       await _checkHighlightsSelectedUnit(wt);
-      await _checkRunCodeWorks(wt);
-      await _checkResizeUnitContent(wt);
+      // TODO(nausharipov): fix tests
+      // await _checkRunCodeWorks(wt);
+      // await _checkResizeUnitContent(wt);

Review Comment:
   Why do we need to disable these (and test checks elsewhere)? Is it related to the changes in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org