You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "dhemery (GitHub)" <gi...@apache.org> on 2018/10/02 00:18:21 UTC

[GitHub] [geode] dhemery opened pull request #2551: GEODE-5805: Extract LoginHandlerInterceptor tests

Several of the tests in `LoginHandlerInterceptorTests` each exercised multiple responsibilities, making it harder to diagnose failures.

This commit extracts those multiple responsibilities into focused tests of their own.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@kirklund @mhansonp @balesh2

[ Full content available at: https://github.com/apache/geode/pull/2551 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 closed pull request #2551: GEODE-5805: Extract LoginHandlerInterceptor tests

Posted by "balesh2 (GitHub)" <gi...@apache.org>.
[ pull request closed by balesh2 ]

[ Full content available at: https://github.com/apache/geode/pull/2551 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org