You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/28 02:59:53 UTC
[GitHub] [pulsar] linlinnn opened a new pull request #10731: [function] fix update user config
linlinnn opened a new pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731
Fixes #10720
### Motivation
fix update user config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864790537
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864706035
@freeznet done, please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864790537
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn closed pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn closed pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-863785343
@nlu90 @freeznet Can you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-850290272
In this way, `userConfigMap ` will be null if user does not set user config. We need to confirm if this will cause Conext.getUserConfigMap() return null. In that condition, user may get NPE if they do not handle null in there function code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-850299348
> In this way, `userConfigMap ` will be null if user does not set user config. We need to confirm if this will cause Conext.getUserConfigMap() return null. In that condition, user may get NPE if they do not handle null in there function code.
@wangjialing218
I think it's a normal case.
Because user always need to judge not null when access a member of object, it's programing specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
nlu90 commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864614690
@linlinnn could you describe what's the difference between your change and the original one?
Based on my understanding, they are kind of equivalent. Your change set the empty hashmap inside the `userConfigString` while the previous one set it after the `if` clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config
Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10731:
URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864676623
@nlu90 The previous one clear `userConfig` if no `userConfigString` provided, and this change keep the `userConfig` same as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org