You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "Christophe Jolif (JIRA)" <br...@portals.apache.org> on 2007/01/16 10:14:28 UTC
[jira] Reopened: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif reopened PB-55:
--------------------------------
I'm sorry to reopen this issue but it seems to me that even though the fixed file as been correctly applied, the call to the fixed method have not been changed.
Here is a patch:
https://issues.apache.org/jira/secure/attachment/12348996/FacesPortlet.java
that should also fix the call.
Thank you very much!
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesPortlet.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org