You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/28 15:13:00 UTC

[GitHub] [arrow] josiahyan commented on a change in pull request #8757: ARROW-8147: [C++] Add google-cloud-cpp to ThirdpartyToolchain

josiahyan commented on a change in pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#discussion_r584312257



##########
File path: ci/conda_env_unix.yml
##########
@@ -19,6 +19,8 @@
 
 autoconf
 ccache
+google-cloud-cpp=1.20.0

Review comment:
       The currently available version in conda (1.24) is incompatible with the way I initially packaged it. I believe I saw in the CI run that `storage_client` was missing or something, as the google-cloud-cpp package has [started namespacing its exports](https://github.com/googleapis/google-cloud-cpp/blob/5bf147226e9333c5106d5fc8b8bba62657eeab97/google/cloud/storage/legacy.cmake.in#L28) (finally!).
   
   Given the hard link against abseil libraries (as gRPC does too), I decided that the version was safer pinned.
   
   I'm hoping to upgrade the dependency when there is code using it (which would be the GCS implementation of the Arrow file interfaces).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org