You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "Aliaksandr Autayeu (Created) (JIRA)" <ji...@apache.org> on 2011/11/10 17:50:51 UTC
[jira] [Created] (OPENNLP-369) loops improved in maxent
loops improved in maxent
------------------------
Key: OPENNLP-369
URL: https://issues.apache.org/jira/browse/OPENNLP-369
Project: OpenNLP
Issue Type: Improvement
Components: Maxent
Affects Versions: maxent-3.0.3-incubating
Reporter: Aliaksandr Autayeu
Priority: Minor
Attachments: 0009-loops-improved-in-maxent.patch
Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OPENNLP-369) loops improved in maxent
Posted by "Joern Kottmann (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joern Kottmann closed OPENNLP-369.
----------------------------------
Resolution: Fixed
Fix Version/s: tools-1.5.3-incubating
We always need a tools version in the fixed field, because we use that one to generate the list of fixed jiras for our distribution.
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Assignee: Joern Kottmann
> Priority: Minor
> Labels: patch
> Fix For: tools-1.5.3-incubating, maxent-3.0.3-incubating
>
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OPENNLP-369) loops improved in maxent
Posted by "Aliaksandr Autayeu (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aliaksandr Autayeu closed OPENNLP-369.
--------------------------------------
Resolution: Fixed
Fix Version/s: maxent-3.0.3-incubating
Thank you for reviewing my patches!
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Fix For: maxent-3.0.3-incubating
>
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OPENNLP-369) loops improved in
maxent
Posted by "Joern Kottmann (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148436#comment-13148436 ]
Joern Kottmann edited comment on OPENNLP-369 at 11/11/11 11:49 AM:
-------------------------------------------------------------------
Mostly applied the patch with a few exceptions.
- No need to enhance code which will be removed anyway (OldFormatGISModelReader)
- In one case there was a nested for loop, but only the outer loop was updated, I kept the old version, should be either two nested for each loops or two nested for loops
- One loop was a bit confusing because of already bad variable naming, should be re-factored to have better variables names and a for each loop (was in one of the Indxer classes)
was (Author: joern):
Mostly applied the patch with a few exceptions.
- No need to enhance code which will be removed any way
- In one case there was a nested for loop, but only the outer loop was updated, I kept the old version, should be either two nested for each loops or two nested for loops
- One loop was a bit confusing because of already bad variable naming, should be re-factored to have better variables names and a for each loop (was in one of the Indxer classes)
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OPENNLP-369) loops improved in maxent
Posted by "Joern Kottmann (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joern Kottmann reopened OPENNLP-369:
------------------------------------
Assignee: Joern Kottmann
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Assignee: Joern Kottmann
> Priority: Minor
> Labels: patch
> Fix For: tools-1.5.3-incubating, maxent-3.0.3-incubating
>
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-369) loops improved in maxent
Posted by "Joern Kottmann (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148465#comment-13148465 ]
Joern Kottmann commented on OPENNLP-369:
----------------------------------------
Should we close this issue?
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OPENNLP-369) loops improved in maxent
Posted by "Aliaksandr Autayeu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aliaksandr Autayeu updated OPENNLP-369:
---------------------------------------
Attachment: 0009-loops-improved-in-maxent.patch
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-369) loops improved in maxent
Posted by "Joern Kottmann (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148436#comment-13148436 ]
Joern Kottmann commented on OPENNLP-369:
----------------------------------------
Mostly applied the patch with a few exceptions.
- No need to enhance code which will be removed any way
- In one case there was a nested for loop, but only the outer loop was updated, I kept the old version, should be either two nested for each loops or two nested for loops
- One loop was a bit confusing because of already bad variable naming, should be re-factored to have better variables names and a for each loop (was in one of the Indxer classes)
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira