You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Flavio Percoco <fl...@gmail.com> on 2015/06/11 17:01:59 UTC

Review Request 35360: PROTON-908: Remove install-runtime dependency on swig

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35360/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Rafael Schloming.


Repository: qpid-proton-git


Description
-------

The patch allows python-qpid-proton for generating the `cproton_wrap.c`
file when creating the distribution package. Since this file is already
cross-platform, it should be safe to ship it as part of the 
python-qpid-proton package.

This allows us for building the bindings even when swig is not 
available. The setup.py process will try to generate a new 
cproton_wrap.c everytime but it'll fallback to the one distributed with
the package if swig is not available.


Note that this will be done just in the platforms where bundling proton-c
is supported. The reason being that, in the other platforms, w can't verify
whether the installed qpid-proton version is the same that was used to
generated these files


Diffs
-----

  proton-c/bindings/python/setup.py 84b5a66 

Diff: https://reviews.apache.org/r/35360/diff/


Testing
-------


Thanks,

Flavio Percoco


Re: Review Request 35360: PROTON-908: Remove install-runtime dependency on swig

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35360/#review88100
-----------------------------------------------------------

Ship it!


Looks good - the python tox tests work as expected, and I can 'python setup.py build install' the sdist file on a machine that does not have swig installed.

- Kenneth Giusti


On June 15, 2015, 10:06 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35360/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 10:06 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> The patch allows python-qpid-proton for generating the `cproton_wrap.c`
> file when creating the distribution package. Since this file is already
> cross-platform, it should be safe to ship it as part of the 
> python-qpid-proton package.
> 
> This allows us for building the bindings even when swig is not 
> available. The setup.py process will try to generate a new 
> cproton_wrap.c everytime but it'll fallback to the one distributed with
> the package if swig is not available.
> 
> 
> Note that this will be done just in the platforms where bundling proton-c
> is supported. The reason being that, in the other platforms, w can't verify
> whether the installed qpid-proton version is the same that was used to
> generated these files
> 
> 
> Diffs
> -----
> 
>   proton-c/CMakeLists.txt 5b05e38 
>   proton-c/bindings/python/setup.py 84b5a66 
> 
> Diff: https://reviews.apache.org/r/35360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>


Re: Review Request 35360: PROTON-908: Remove install-runtime dependency on swig

Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35360/
-----------------------------------------------------------

(Updated June 15, 2015, 10:06 p.m.)


Review request for qpid, Gordon Sim and Rafael Schloming.


Changes
-------

This patch addresses Ken's comments.


cmake now exports the QPID_SRC_PROTON env variable itself. To run this `build` tests using pure tox, the env var will have to be exported manually for now since it's needed by the sdist step which is executed before `tox` exports the registered env variables.


Repository: qpid-proton-git


Description
-------

The patch allows python-qpid-proton for generating the `cproton_wrap.c`
file when creating the distribution package. Since this file is already
cross-platform, it should be safe to ship it as part of the 
python-qpid-proton package.

This allows us for building the bindings even when swig is not 
available. The setup.py process will try to generate a new 
cproton_wrap.c everytime but it'll fallback to the one distributed with
the package if swig is not available.


Note that this will be done just in the platforms where bundling proton-c
is supported. The reason being that, in the other platforms, w can't verify
whether the installed qpid-proton version is the same that was used to
generated these files


Diffs (updated)
-----

  proton-c/CMakeLists.txt 5b05e38 
  proton-c/bindings/python/setup.py 84b5a66 

Diff: https://reviews.apache.org/r/35360/diff/


Testing
-------


Thanks,

Flavio Percoco


Re: Review Request 35360: PROTON-908: Remove install-runtime dependency on swig

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35360/#review87970
-----------------------------------------------------------


This patch breaks my ability to run the python-tox-test correctly.   With this patch, when I run 'make test' (or ctest -R python-tox-test), tox attempts to pull down the proton sources from apache.   This should not happen when running 'make test or ctest' - tox should use the local sources in those cases.


proton-c/bindings/python/setup.py
<https://reviews.apache.org/r/35360/#comment140376>

    I didn't realize this call actually runs swig.  Can you drop a comment?


- Kenneth Giusti


On June 11, 2015, 3:03 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35360/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 3:03 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> The patch allows python-qpid-proton for generating the `cproton_wrap.c`
> file when creating the distribution package. Since this file is already
> cross-platform, it should be safe to ship it as part of the 
> python-qpid-proton package.
> 
> This allows us for building the bindings even when swig is not 
> available. The setup.py process will try to generate a new 
> cproton_wrap.c everytime but it'll fallback to the one distributed with
> the package if swig is not available.
> 
> 
> Note that this will be done just in the platforms where bundling proton-c
> is supported. The reason being that, in the other platforms, w can't verify
> whether the installed qpid-proton version is the same that was used to
> generated these files
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/setup.py 84b5a66 
> 
> Diff: https://reviews.apache.org/r/35360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>


Re: Review Request 35360: PROTON-908: Remove install-runtime dependency on swig

Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35360/
-----------------------------------------------------------

(Updated June 11, 2015, 3:03 p.m.)


Review request for qpid, Gordon Sim and Rafael Schloming.


Changes
-------

removed dumb comment


Repository: qpid-proton-git


Description
-------

The patch allows python-qpid-proton for generating the `cproton_wrap.c`
file when creating the distribution package. Since this file is already
cross-platform, it should be safe to ship it as part of the 
python-qpid-proton package.

This allows us for building the bindings even when swig is not 
available. The setup.py process will try to generate a new 
cproton_wrap.c everytime but it'll fallback to the one distributed with
the package if swig is not available.


Note that this will be done just in the platforms where bundling proton-c
is supported. The reason being that, in the other platforms, w can't verify
whether the installed qpid-proton version is the same that was used to
generated these files


Diffs (updated)
-----

  proton-c/bindings/python/setup.py 84b5a66 

Diff: https://reviews.apache.org/r/35360/diff/


Testing
-------


Thanks,

Flavio Percoco