[GitHub] [iceberg] findepi commented on pull request #4978: Annotate selected FileScanTask attributes as not null

[GitBox <gi...@apache.org>]

findepi commented on PR #4978:
URL: https://github.com/apache/iceberg/pull/4978#issuecomment-1153670663

   > as opposed to introducing dependencies on projects like findbugs or related IDE or framework based annotations.
   
   i think i picked `edu.umd.cs.findbugs.annotations.NonNull` because that was readily available on the classpath, but i agree it wasn't the best choice.
   
   AFAICT `javax.validation.constraints.NotNull` is preferred for bean validation, and not preferred for defining contracts, so  I  switched to `javax.annotation.Nonnull`. 
   
   @danielcweeks can you please take another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org