You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/02 06:43:54 UTC
[GitHub] [inlong] gosonzhang opened a new issue, #6369: [Improve][DataProxy] Use the defined message attribute Key value in InLong-Common
gosonzhang opened a new issue, #6369:
URL: https://github.com/apache/inlong/issues/6369
### Description
When dealing with pr[1], I found that DataProxy separately defines the property Key value for message interaction between SDK and DataProxy. This information should be placed in InLong-Common, so that when dealing with cross-module content, the same Key It can avoid repeated definitions, or the problem that the key value is defined incorrectly and the corresponding value cannot be obtained.
1. https://github.com/apache/inlong/pull/6351
### InLong Component
InLong DataProxy
### Are you willing to submit PR?
- [X] Yes, I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang closed issue #6369: [Improve][DataProxy] Use the defined message attribute key value in InLong-Common
Posted by GitBox <gi...@apache.org>.
gosonzhang closed issue #6369: [Improve][DataProxy] Use the defined message attribute key value in InLong-Common
URL: https://github.com/apache/inlong/issues/6369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #6369: [Improve][DataProxy] Use the defined message attribute Key value in InLong-Common
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #6369:
URL: https://github.com/apache/inlong/issues/6369#issuecomment-1301629975
I made the following changes in the PR (https://github.com/apache/inlong/pull/6386) :
Change all message attribute Keys generated by SDK and used by DataProxy or other modules to be obtained from org.apache.inlong.common.msg.AttributeConstants;
The message attribute Key generated by DataProxy and returned to the receiver through the message attribute is placed in the org.apache.inlong.common.msg.AttributeConstants file, and the generation direction is marked;
Change the file name of org.apache.inlong.dataproxy.consts.AttributeConstants to org.apache.inlong.dataproxy.consts.AttrConstants to avoid confusing references with the same name as org.apache.inlong.common.msg.AttributeConstants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org