You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2018/02/12 22:03:00 UTC

[jira] [Created] (SOLR-11977) QEC editorialMarkerFieldName & excludeMarkerFieldName are confusing and silly

Hoss Man created SOLR-11977:
-------------------------------

             Summary: QEC editorialMarkerFieldName & excludeMarkerFieldName are confusing and silly
                 Key: SOLR-11977
                 URL: https://issues.apache.org/jira/browse/SOLR-11977
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Hoss Man


QueryElevationComponent suppports 2 initParams that are weird and very inconsistent with how similar features in solr work...
* editorialMarkerFieldName
* excludeMarkerFieldName

These init params simply provide an "override" to the names "elevated" and "excluded" that are used in {{QueryElevationComponent.inform(SolrCore)}} to change the names used when registering instances of EditorialMarkerFactory and ExcludedMarkerFactory as DocTransformers.

This makes no sense -- we already have a standard mechanism for people to override the default names used by doc transformers.

We should:
# deprecated & remove & undocument these options and remove the relvant code from QEC
# add these transformers to {{TransformerFactory.defaultFactories}} using their default names

... users that have a strong desire to override these names should do so by explicitly registering them as {{<transformer name="..."}} just like an other DocTransformer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org