You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/28 12:53:54 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6173: nuttx: fix coverity check error

pkarashchenko commented on code in PR #6173:
URL: https://github.com/apache/incubator-nuttx/pull/6173#discussion_r860852802


##########
sched/pthread/pthread_mutexinit.c:
##########
@@ -124,11 +117,20 @@ int pthread_mutex_init(FAR pthread_mutex_t *mutex,
 #endif
 
 #ifndef CONFIG_PTHREAD_MUTEX_UNSAFE
-      /* Initial internal fields of the mutex */
 
       mutex->flink  = NULL;
+
+#ifdef CONFIG_PTHREAD_MUTEX_BOTH
+      /* Initial internal fields of the mutex */
+
       mutex->flags  = (robust == PTHREAD_MUTEX_ROBUST ?

Review Comment:
   If you removed `uint8_t robust` at lines 72 and 74, then what is checked here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org