You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/28 09:04:11 UTC

[GitHub] [cloudstack] Yashikaone opened a new pull request #5907: Improving code readability using optional chaining

Yashikaone opened a new pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907


    **DESCRIPTION**
   
     This PR is related to issue #4956. 
     This is my first contribution on Github and I have no experience with javascript therefore I have tried changing a single file for now. 
     Please let me know if there is an error I will be happy to rectify it as soon as possible.
    Thank you
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907#issuecomment-1024026443


   @Yashikaone Optional chaining is not recommended for <template> elements. Because this will cause the build to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Yashikaone commented on pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
Yashikaone commented on pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907#issuecomment-1024031830


   @utchoang Thank you for the review, I will keep this in mind. 
   Also I have a question, does optional chaining works for only null references ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Yashikaone commented on pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
Yashikaone commented on pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907#issuecomment-1024052522


   Okay Thank you for your help. I will close this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907#issuecomment-1024026443


   @Yashikaone Optional chaining is not recommended for `<template>` elements. Because this will cause the build to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907#issuecomment-1024050994


   @Yashikaone Yes. As far as I remember it works with null reference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Yashikaone closed pull request #5907: Improving code readability using optional chaining

Posted by GitBox <gi...@apache.org>.
Yashikaone closed pull request #5907:
URL: https://github.com/apache/cloudstack/pull/5907


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org