[GitHub] [incubator-yunikorn-release] yangwwei commented on a change in pull request #7: [YUNIKORN-167] Fixed release tool after helm chart related changes

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #7:
URL: https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r436077143



##########
File path: docs/release-procedure.md
##########
@@ -91,3 +92,15 @@ Once the voting is passed, move the release artifacts to https://dist.apache.org
 
 Publish an announcement blog to https://blogs.apache.org/yunikorn/, update the web-site with corresponding
 release notes, download links.
+
+# Release Helm Charts
+
+After the voting passed and the RC is accepted, release the helm chart
+- Create a release branch for the target release in this release repo
+- Package the charts: 
+```shell script
+helm package helm-charts/yunikorn --destination .

Review comment:
       can you please include the doc about how to sign a helm-chart-tarball?

##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
     release_base = os.path.join(staging_dir, release_package_name)
     release_top_path = os.path.join(os.path.dirname(tools_dir),
         "release-top-level-artifacts")
+    helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+        "helm-charts")

Review comment:
       the changes for this file seems not enough.
   because the helm charts file in this dir is hard-coded to 0.8.
   can we add a folder for all helm-chart files, and each released version can have one on its own? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org