You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/02/28 21:56:24 UTC
Review Request 72179: Got rid of passing Shared<> into
`Subscribers::Subscriber::send(...)`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72179/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10057
https://issues.apache.org/jira/browse/MESOS-10057
Repository: mesos
Description
-------
Now that operator API events are authorized synchronously,
`Subscribers::Subscriber::send(...)` is no longer deferred,
and copying arguments of `Subscribers::send()` into `Shared`
becomes unnecessary.
Diffs
-----
src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372
src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177
Diff: https://reviews.apache.org/r/72179/diff/1/
Testing
-------
make check
Thanks,
Andrei Sekretenko
Re: Review Request 72179: Got rid of passing Shared<> into
`Subscribers::Subscriber::send(...)`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72179/#review219703
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 28, 2020, 9:56 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72179/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2020, 9:56 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10057
> https://issues.apache.org/jira/browse/MESOS-10057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now that operator API events are authorized synchronously,
> `Subscribers::Subscriber::send(...)` is no longer deferred,
> and copying arguments of `Subscribers::send()` into `Shared`
> becomes unnecessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372
> src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177
>
>
> Diff: https://reviews.apache.org/r/72179/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72179: Got rid of passing Shared<> into
`Subscribers::Subscriber::send(...)`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72179/#review219704
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72130, 72094, 72095, 72089, 72093, 72096, 72097, 72169, 72098, 72099, 72170, 72178, 72179]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Feb. 28, 2020, 9:56 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72179/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2020, 9:56 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10057
> https://issues.apache.org/jira/browse/MESOS-10057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now that operator API events are authorized synchronously,
> `Subscribers::Subscriber::send(...)` is no longer deferred,
> and copying arguments of `Subscribers::send()` into `Shared`
> becomes unnecessary.
>
>
> Diffs
> -----
>
> src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372
> src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177
>
>
> Diff: https://reviews.apache.org/r/72179/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Sekretenko
>
>