You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/02 04:22:43 UTC
[GitHub] [spark] amaliujia commented on a diff in pull request #37039: [SPARK-39649][PYTHON] Make listDatabases / getDatabase / listColumns / refreshTable in PySpark support 3-layer-namespace
amaliujia commented on code in PR #37039:
URL: https://github.com/apache/spark/pull/37039#discussion_r912317990
##########
python/pyspark/sql/catalog.py:
##########
@@ -139,11 +140,40 @@ def listDatabases(self) -> List[Database]:
jdb = iter.next()
databases.append(
Database(
- name=jdb.name(), description=jdb.description(), locationUri=jdb.locationUri()
+ name=jdb.name(),
+ catalog=jdb.catalog(),
+ description=jdb.description(),
+ locationUri=jdb.locationUri(),
)
)
return databases
+ def getDatabase(self, dbName: str) -> Database:
+ """Get the database with the specified name.
+ This throws an AnalysisException when the database cannot be found.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ dbName : str
+ name of the database to check existence.
+
+ Examples
+ --------
+ >>> spark.catalog.getDatabase("default")
+ Database(name='default', catalog=None, description='default database', ...
Review Comment:
I was not aware of this though:
Is the `catalog=None` because of current catalog is not set? I am asking because I thought every DB should have a catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org