You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "anishmehta24 (via GitHub)" <gi...@apache.org> on 2026/10/11 01:51:06 UTC
[PR] [Python] Fix DataFrame Series.value_counts with bins [beam]
anishmehta24 opened a new pull request, #40505:
URL: https://github.com/apache/beam/pull/40505
Fixes #40503
`[self._expr]` was inside the lambda in the `bins` branch of `value_counts`, so `ComputedExpression` was created without its args and always raised a `TypeError`. This moves it out, and builds the proxy from a one-element Series since pandas can't compute bins for the empty proxy. Added a test to frames_test.py and a CHANGES.md entry.
Written with help from Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Fix DataFrame Series.value_counts with bins [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40505:
URL: https://github.com/apache/beam/pull/40505#issuecomment-6104593637
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40505?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.24%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d6ee0d`](https://app.codecov.io/gh/apache/beam/commit/8d6ee0dcb154ee6ba1a9f0a64476c1ee8a9892b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 111 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40505 +/- ##
============================================
+ Coverage 56.16% 56.24% +0.07%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178361 +25
Branches 1489 1489
============================================
+ Hits 100170 100311 +141
+ Misses 75645 75529 -116
Partials 2521 2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40505/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/40505/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.70% <100.00%> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40505?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Fix DataFrame Series.value_counts with bins [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #40505:
URL: https://github.com/apache/beam/pull/40505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Fix DataFrame Series.value_counts with bins [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40505:
URL: https://github.com/apache/beam/pull/40505#issuecomment-6104989616
Assigning reviewers:
R: @shunping for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Fix DataFrame Series.value_counts with bins [beam]
Posted by "anishmehta24 (via GitHub)" <gi...@apache.org>.
anishmehta24 commented on PR #40505:
URL: https://github.com/apache/beam/pull/40505#issuecomment-6133599318
Rebased on master and kept both CHANGES.md entries. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org