You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/08/18 14:47:00 UTC
[GitHub] incubator-pirk pull request #69: Removed unused variables, general code clea...
GitHub user smarthi opened a pull request:
https://github.com/apache/incubator-pirk/pull/69
Removed unused variables, general code clean up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarthi/incubator-pirk sundry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit c30ca0d1d06c5c15f59351042886ba9d8b780c09
Author: smarthi <sm...@apache.org>
Date: 2016-08-18T14:46:22Z
Removed unused variables, general code clean up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #69: Removed unused variables, general code clea...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324999
--- Diff: src/main/java/org/apache/pirk/schema/query/QuerySchemaLoader.java ---
@@ -296,7 +296,7 @@ private Document parseXMLDocument(InputStream stream) throws IOException, PIRExc
* @param doc
* An XML document specifying names upon which we will filter the query.
* @return The set of names upon which we will filter the query.
- * @throws PIRException
+ * @throws PIRException -
--- End diff --
I'd rather keep the warnings than read this throws comment :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #69: Removed unused variables, general code clean up
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/69
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #69: Removed unused variables, general code clea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #69: Removed unused variables, general code clea...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75324702
--- Diff: src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -316,23 +311,15 @@ public void performQuery() throws Exception
/**
* Method to perform the query given an input RDD of MapWritables
- *
+ *
*/
public void performQuery(JavaRDD<MapWritable> inputRDD) throws PIRException
{
logger.info("Performing query: ");
- // If we are using distributed exp tables -- Create the expTable file in hdfs for this query, if it doesn't exist
- if ((queryInfo.getUseHDFSExpLookupTable() || useHDFSLookupTable) && query.getExpFileBasedLookup().isEmpty())
- {
- // <queryHash, <<power>,<element^power mod N^2>>
- JavaPairRDD<Integer,Iterable<Tuple2<Integer,BigInteger>>> expCalculations = ComputeExpLookupTable.computeExpTable(sc, fs, bVars, query, queryInput,
--- End diff --
Is this removal safe? Although the return value is ignored, the compute method has the side-effect of creating the exponent look-up table in HDFS, and storing it in the Query.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #69: Removed unused variables, general code clean up
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/69
@tellison could u review again? Updated the PR addressing ur previous comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #69: Removed unused variables, general code clea...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/69#discussion_r75327898
--- Diff: src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
@@ -316,23 +311,15 @@ public void performQuery() throws Exception
/**
* Method to perform the query given an input RDD of MapWritables
- *
+ *
*/
public void performQuery(JavaRDD<MapWritable> inputRDD) throws PIRException
{
logger.info("Performing query: ");
- // If we are using distributed exp tables -- Create the expTable file in hdfs for this query, if it doesn't exist
- if ((queryInfo.getUseHDFSExpLookupTable() || useHDFSLookupTable) && query.getExpFileBasedLookup().isEmpty())
- {
- // <queryHash, <<power>,<element^power mod N^2>>
- JavaPairRDD<Integer,Iterable<Tuple2<Integer,BigInteger>>> expCalculations = ComputeExpLookupTable.computeExpTable(sc, fs, bVars, query, queryInput,
--- End diff --
It seems 'Safely Unsafe', will revert this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---