You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/06/18 08:23:22 UTC

Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.


Bugs: AMBARI-11989
    https://issues.apache.org/jira/browse/AMBARI-11989


Repository: ambari


Description
-------

Moved the Atlas driver code in the Linux-specific implementation.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 

Diff: https://reviews.apache.org/r/35594/diff/


Testing
-------

mvn clean test -> local VM deployment -> ok


Thanks,

Florian Barca

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Jayush Luniya <jl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88398
-----------------------------------------------------------


Please deploy on Linux before committing.

- Jayush Luniya


On June 18, 2015, 6:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Florian Barca <fb...@hortonworks.com>.


> On June 18, 2015, 5:07 p.m., Andrew Onischuk wrote:
> > maybe it would more readable to move it inside webhcat() func?

Possibly, but Atlas is a separate component, so I thought it makes more sense to keep the code separate and not mix it up.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88400
-----------------------------------------------------------


On June 18, 2015, 6:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Andrew Onischuk <ao...@hortonworks.com>.


> On June 18, 2015, 5:07 p.m., Andrew Onischuk wrote:
> > maybe it would more readable to move it inside webhcat() func?
> 
> Florian Barca wrote:
>     Possibly, but Atlas is a separate component, so I thought it makes more sense to keep the code separate and not mix it up.

We do that actually for hive_client and hive_server, meaning put the function into hive() function so maybe that would be good thing to unify that.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88400
-----------------------------------------------------------


On June 18, 2015, 6:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Andrew Onischuk <ao...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88400
-----------------------------------------------------------

Ship it!


maybe it would more readable to move it inside webhcat() func?

- Andrew Onischuk


On June 18, 2015, 6:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Florian Barca <fb...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/
-----------------------------------------------------------

(Updated June 18, 2015, 9:48 p.m.)


Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.


Changes
-------

Per Andrew's feedback, moved the atlas init routines inside hcat() and webhcat().


Bugs: AMBARI-11989
    https://issues.apache.org/jira/browse/AMBARI-11989


Repository: ambari


Description
-------

Moved the Atlas driver code in the Linux-specific implementation.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py 1f7893d6721add8ea5910786b7e6a7459ba71bba 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py c33bc9026164efd21095f1813c643546e6ba1a75 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 

Diff: https://reviews.apache.org/r/35594/diff/


Testing
-------

mvn clean test -> local VM deployment -> ok


Thanks,

Florian Barca

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Jayush Luniya <jl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88397
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On June 18, 2015, 6:23 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:23 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>

Re: Review Request 35594: [WinTP2] Atlas is not supported on Windows for TP2

Posted by Artem Baranchuk <ab...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35594/#review88439
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Baranchuk


On Июнь 18, 2015, 6:23 д.п., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35594/
> -----------------------------------------------------------
> 
> (Updated Июнь 18, 2015, 6:23 д.п.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11989
>     https://issues.apache.org/jira/browse/AMBARI-11989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Moved the Atlas driver code in the Linux-specific implementation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 1b5b76875423c9926d58ce5b068ea57b9d7ce480 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 0473d1753a6f9f7b542a61b14f495ba21bb02246 
> 
> Diff: https://reviews.apache.org/r/35594/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -> local VM deployment -> ok
> 
> 
> Thanks,
> 
> Florian Barca
> 
>