You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by ThisuraThejith <gi...@git.apache.org> on 2017/03/09 12:57:27 UTC
[GitHub] incubator-fineract pull request #307: Resolved-Sonar-Issues
GitHub user ThisuraThejith opened a pull request:
https://github.com/apache/incubator-fineract/pull/307
Resolved-Sonar-Issues
Resolved the coding issues reported by sonar in org.apache.fineract.accounting module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThisuraThejith/incubator-fineract develop-Sonar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit 7eca30285860edd4183293d8311898edf6d5c2cc
Author: ThisuraThejith <tt...@gmail.com>
Date: 2017-03-06T05:43:37Z
resolved sonar errors in BatchApiResource
commit cf0ef6a05adbbfba195cda1757ab3054210e2b98
Author: ThisuraThejith <tt...@gmail.com>
Date: 2017-03-08T05:48:58Z
Merge branch 'develop' of https://github.com/apache/incubator-fineract into develop-Sonar
commit bfce508c7d48f8b9e26b85e957ef73378071a907
Author: ThisuraThejith <tt...@gmail.com>
Date: 2017-03-09T12:53:08Z
Fixed coding issues reported by sonar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #307: Resolved-Sonar-Issues
Posted by ThisuraThejith <gi...@git.apache.org>.
Github user ThisuraThejith closed the pull request at:
https://github.com/apache/incubator-fineract/pull/307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #307: Resolved-Sonar-Issues
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on the issue:
https://github.com/apache/incubator-fineract/pull/307
@ThisuraThejith Please close this PR as we are not expecting coding style changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #307: Resolved-Sonar-Issues
Posted by ThisuraThejith <gi...@git.apache.org>.
Github user ThisuraThejith commented on the issue:
https://github.com/apache/incubator-fineract/pull/307
Closed upon request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #307: Resolved-Sonar-Issues
Posted by nikpawar89 <gi...@git.apache.org>.
Github user nikpawar89 commented on the issue:
https://github.com/apache/incubator-fineract/pull/307
@ThisuraThejith As specified in the email response, we are more interested in security vulnerabilities rather than code quality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---