You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org> on 2005/02/12 03:49:12 UTC
[jira] Created: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
The Length' s nuber of byte must not be 127
-------------------------------------------
Key: DIRSNICKERS-102
URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
Project: Directory Snickers
Type: Bug
Components: BER Runtime
Reporter: Emmanuel Lecharny
Attachments: Length-branches.diff, Length-trunk.diff
in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
Diff files attached.
Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DIRSNICKERS-102) The Length' s nuber of byte
must not be 127
Posted by Alex Karasulu <ao...@bellsouth.net>.
Vincent Tence wrote:
>> Those are two test cases related to the issue.
>> The Undefinite Length form is not allowed by RFC 2251 : chapter 5.1,
>> limitation (1), so it could make sense to throw an exception in this
>> particullary case. However, it may seems a little bit restrictive, so
>> I suggest that a configuration flag should be use to allow or
>> disallow this feature.
>>
>> The point is : are we trying to build a generic ASN.1 compliant
>> decoder, or a specific one.
>
>
> I am gald you brough that point up Emmanuel, and I'd like to know what
> the other guys think about this. What the best approach for us?
>
> 1. Build specific component and grow them to generic ones later on if
> there's a need.
>
> 2. Try to build generic components from the start
>
> I would favor #1, so we concentrate our energies on our needs and we
> build the best API for what we have to do. We can then evaluate
> opportunities for extracting generic components.
>
> Opinions?
+1 I agree.
The only subtle difference for me is that I would use interfaces and
hierarchy to differentiate the codecs. Like for example DER is a subset
of BER and some would just say its constrained BER. Also note that the
LDAP BER is not full BER, it too is a subset. So when we build a
decoder for example it might be nice to have the same interfaces and
swap out the underlying implementation when we want.
Cheers,
Alex
Re: [jira] Updated: (DIRSNICKERS-102) The Length' s nuber of byte must
not be 127
Posted by Vincent Tence <vt...@videotron.ca>.
> Those are two test cases related to the issue.
>
> The Undefinite Length form is not allowed by RFC 2251 : chapter 5.1, limitation (1), so it could make sense to throw an exception in this particullary case. However, it may seems a little bit restrictive, so I suggest that a configuration flag should be use to allow or disallow this feature.
>
> The point is : are we trying to build a generic ASN.1 compliant decoder, or a specific one.
I am gald you brough that point up Emmanuel, and I'd like to know what
the other guys think about this. What the best approach for us?
1. Build specific component and grow them to generic ones later on if
there's a need.
2. Try to build generic components from the start
I would favor #1, so we concentrate our energies on our needs and we
build the best API for what we have to do. We can then evaluate
opportunities for extracting generic components.
Opinions?
- Vincent
[jira] Updated: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Emmanuel Lecharny updated DIRSNICKERS-102:
------------------------------------------
Attachment: LengthTest-trunk.diff
LengthTest-branche.diff
Those are two test cases related to the issue.
The Undefinite Length form is not allowed by RFC 2251 : chapter 5.1, limitation (1), so it could make sense to throw an exception in this particullary case. However, it may seems a little bit restrictive, so I suggest that a configuration flag should be use to allow or disallow this feature.
The point is : are we trying to build a generic ASN.1 compliant decoder, or a specific one.
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=comments#action_59765 ]
Alan Cabrera commented on DIRSNICKERS-102:
------------------------------------------
In the future, patches should include the path starting from asn1. This will make it easier to apply the patches.
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alan Cabrera
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Alex Karasulu reassigned DIRSNICKERS-102:
-----------------------------------------
Assign To: Alex Karasulu
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alex Karasulu
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Alan Cabrera reassigned DIRSNICKERS-102:
----------------------------------------
Assign To: Emmanuel Lecharny (was: Alan Cabrera)
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Alan Cabrera resolved DIRSNICKERS-102:
--------------------------------------
Resolution: Fixed
Thanks E!
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alan Cabrera
> Attachments: asn1.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Alan Cabrera reassigned DIRSNICKERS-102:
----------------------------------------
Assign To: Alan Cabrera (was: Emmanuel Lecharny)
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alan Cabrera
> Attachments: asn1.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=comments#action_59838 ]
Emmanuel Lecharny commented on DIRSNICKERS-102:
-----------------------------------------------
The initial patch was a little bit too restrictive, as it didn't allowed indefinite length forms. It has been corrected in Length.java, and in the added unit test (asn1.diff).
I tested the whole project, runing the command :
maven -Dgoal=test multiproject:goal
in all projects, without any problem.
A double check could help ! (Alan ?)
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff, asn1.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Emmanuel Lecharny updated DIRSNICKERS-102:
------------------------------------------
Attachment: Length-trunk.diff
Length-branches.diff
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Alan Cabrera reassigned DIRSNICKERS-102:
----------------------------------------
Assign To: Alan Cabrera (was: Alex Karasulu)
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alan Cabrera
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=history ]
Emmanuel Lecharny updated DIRSNICKERS-102:
------------------------------------------
Attachment: asn1.diff
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff, asn1.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=comments#action_59055 ]
Emmanuel Lecharny commented on DIRSNICKERS-102:
-----------------------------------------------
I marked it as Major because a manually hand crafted TLV encoded like this : 0x04 0xFF ... could totally broke the decoding, I bet.
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Attachments: Length-branches.diff, Length-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRSNICKERS-102) The Length' s nuber of byte must not be 127
Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRSNICKERS-102?page=comments#action_59766 ]
Alan Cabrera commented on DIRSNICKERS-102:
------------------------------------------
This fix seems to make other tests fail.
> The Length' s nuber of byte must not be 127
> -------------------------------------------
>
> Key: DIRSNICKERS-102
> URL: http://issues.apache.org/jira/browse/DIRSNICKERS-102
> Project: Directory Snickers
> Type: Bug
> Components: BER Runtime
> Reporter: Emmanuel Lecharny
> Assignee: Alan Cabrera
> Attachments: Length-branches.diff, Length-trunk.diff, LengthTest-branche.diff, LengthTest-trunk.diff
>
> in class Length (/asn1-ber/src/java/org/apache/asn1/ber/Lengrh.java, in both trunk and branches), the number of bytes that is necessary to encode the Value length MUST NOT be == 127 (this value is reserved for future extension : ITU-T X690, 8.1.3.5, c))
> I don't think that we have to deal with indefinite length, and I expect so, because the code does not accept thid kind f Length.
> Diff files attached.
> Unit Test TBD.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira