You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2014/06/16 21:02:48 UTC
Review Request 22598: added an interface to get host IP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22598/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
Routing: added an interface to get host public IP.
Diffs
-----
src/linux/routing/utils.hpp a3d914a
src/linux/routing/utils.cpp 80b62d0
src/tests/routing_tests.cpp 0e8f61a
Diff: https://reviews.apache.org/r/22598/diff/
Testing
-------
make check
Thanks,
Chi Zhang
Re: Review Request 22598: added an interface to get host IP
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22598/#review46421
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 16, 2014, 7:02 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22598/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 7:02 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Routing: added an interface to get host public IP.
>
>
> Diffs
> -----
>
> src/linux/routing/utils.hpp a3d914a
> src/linux/routing/utils.cpp 80b62d0
> src/tests/routing_tests.cpp 0e8f61a
>
> Diff: https://reviews.apache.org/r/22598/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 22598: added an interface to get host IP
Posted by Chi Zhang <ch...@gmail.com>.
> On June 27, 2014, 12:16 a.m., Jie Yu wrote:
> > I think in most of the cases, if you need hostIP, you will need eth0 name too. So I don't think this function is quite useful. I would suggest postpone this patch until we see a use case.
i am okay with that. originally added because network isolator could use it. turns out not. i don't have a serious use case in mind other than maybe they could be useful for some test cases, to quickly get an answer.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22598/#review46816
-----------------------------------------------------------
On June 27, 2014, 12:12 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22598/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 12:12 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Routing: added an interface to get host public IP.
>
>
> Diffs
> -----
>
> src/linux/routing/utils.hpp a3d914a
> src/linux/routing/utils.cpp 80b62d0
> src/tests/routing_tests.cpp 0e8f61a
>
> Diff: https://reviews.apache.org/r/22598/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 22598: added an interface to get host IP
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22598/#review46816
-----------------------------------------------------------
I think in most of the cases, if you need hostIP, you will need eth0 name too. So I don't think this function is quite useful. I would suggest postpone this patch until we see a use case.
- Jie Yu
On June 27, 2014, 12:12 a.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22598/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 12:12 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Routing: added an interface to get host public IP.
>
>
> Diffs
> -----
>
> src/linux/routing/utils.hpp a3d914a
> src/linux/routing/utils.cpp 80b62d0
> src/tests/routing_tests.cpp 0e8f61a
>
> Diff: https://reviews.apache.org/r/22598/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 22598: added an interface to get host IP
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22598/
-----------------------------------------------------------
(Updated June 27, 2014, 12:12 a.m.)
Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang.
Changes
-------
remove dependency since it's checked in already.
Repository: mesos-git
Description
-------
Routing: added an interface to get host public IP.
Diffs
-----
src/linux/routing/utils.hpp a3d914a
src/linux/routing/utils.cpp 80b62d0
src/tests/routing_tests.cpp 0e8f61a
Diff: https://reviews.apache.org/r/22598/diff/
Testing
-------
make check
Thanks,
Chi Zhang