You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fluo.apache.org by kenneth mcfarland <ke...@gmail.com> on 2018/06/01 15:46:59 UTC
Re: [GitHub] keith-turner commented on a change in pull request
#1035: Fluo 1000
It seems the older versions don't blow up like 2.12. although 4.0.1 is
actually the newest but the API was reworked and its incompatible as is.
I'm playing around and 2.9 doesn't blow up like 2.12 so I'm gonna see how
far it will go without emitting a plethora of leader errors, not very
scientific approach but maybe will reveal something when cross referenced
with the release notes.
On Fri, Jun 1, 2018, 6:22 AM GitBox <gi...@apache.org> wrote:
> keith-turner commented on a change in pull request #1035: Fluo 1000
> URL: https://github.com/apache/fluo/pull/1035#discussion_r192393659
>
>
>
> ##########
> File path:
> modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
> ##########
> @@ -196,6 +196,10 @@ public OracleServer(Environment env) throws
> Exception {
> private void allocateTimestamp() throws Exception {
> Stat stat = new Stat();
>
> + while
> (curatorFramework.getState().equals(CuratorFrameworkState.LATENT)) {
>
> Review comment:
> This fixes a problem, but not the problem we are currently seeing.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
Re: [GitHub] keith-turner commented on a change in pull request
#1035: Fluo 1000
Posted by Keith Turner <ke...@deenlo.com>.
On Fri, Jun 1, 2018 at 11:46 AM, kenneth mcfarland
<ke...@gmail.com> wrote:
> It seems the older versions don't blow up like 2.12. although 4.0.1 is
> actually the newest but the API was reworked and its incompatible as is.
>
> I'm playing around and 2.9 doesn't blow up like 2.12 so I'm gonna see how
> far it will go without emitting a plethora of leader errors, not very
> scientific approach but maybe will reveal something when cross referenced
> with the release notes.
One of the things I did while looking into this was to look at the
changes to LeaderSelector by checking out curator and running :
git log -p -- ./curator-recipes/src/main/java/org/apache/curator/framework/recipes/leader/LeaderSelector.java
Then I searched for "The leader threw an exception" in the diffs and
followed those changes.
>
>
>
> On Fri, Jun 1, 2018, 6:22 AM GitBox <gi...@apache.org> wrote:
>
>> keith-turner commented on a change in pull request #1035: Fluo 1000
>> URL: https://github.com/apache/fluo/pull/1035#discussion_r192393659
>>
>>
>>
>> ##########
>> File path:
>> modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
>> ##########
>> @@ -196,6 +196,10 @@ public OracleServer(Environment env) throws
>> Exception {
>> private void allocateTimestamp() throws Exception {
>> Stat stat = new Stat();
>>
>> + while
>> (curatorFramework.getState().equals(CuratorFrameworkState.LATENT)) {
>>
>> Review comment:
>> This fixes a problem, but not the problem we are currently seeing.
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
>>