You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2023/06/09 00:47:46 UTC
[doris] branch master updated: [improvement](recover) Default disable check tablet path (#20565)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new bd5a26f240 [improvement](recover) Default disable check tablet path (#20565)
bd5a26f240 is described below
commit bd5a26f240d881423247d3d7578d8f40e3143d89
Author: yujun <yu...@gmail.com>
AuthorDate: Fri Jun 9 08:47:39 2023 +0800
[improvement](recover) Default disable check tablet path (#20565)
change check tablet path interval's default value to -1
---
be/src/common/config.cpp | 2 +-
be/src/common/config.h | 2 +-
be/src/olap/olap_server.cpp | 9 ++++++---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 20f404efdd..f23bbffe99 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -999,7 +999,7 @@ DEFINE_Int32(max_depth_of_expr_tree, "600");
DEFINE_mInt64(max_tablet_io_errors, "-1");
// Report a tablet as bad when its path not found
-DEFINE_mInt32(tablet_path_check_interval_seconds, "60");
+DEFINE_Int32(tablet_path_check_interval_seconds, "-1");
DEFINE_mInt32(tablet_path_check_batch_size, "1000");
// Page size of row column, default 4KB
diff --git a/be/src/common/config.h b/be/src/common/config.h
index fde9c69718..7b61e13c92 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1015,7 +1015,7 @@ DECLARE_Int32(max_depth_of_expr_tree);
DECLARE_mInt64(max_tablet_io_errors);
// Report a tablet as bad when its path not found
-DECLARE_mInt32(tablet_path_check_interval_seconds);
+DECLARE_Int32(tablet_path_check_interval_seconds);
DECLARE_mInt32(tablet_path_check_batch_size);
// Page size of row column, default 4KB
diff --git a/be/src/olap/olap_server.cpp b/be/src/olap/olap_server.cpp
index 4e300c5460..9d748af254 100644
--- a/be/src/olap/olap_server.cpp
+++ b/be/src/olap/olap_server.cpp
@@ -407,11 +407,14 @@ void StorageEngine::_tablet_path_check_callback() {
};
using TabletQueue = std::priority_queue<Tablet*, std::vector<Tablet*>, TabletIdComparator>;
- int64_t last_tablet_id;
- int64_t interval;
+ int64_t interval = config::tablet_path_check_interval_seconds;
+ if (interval <= 0) {
+ return;
+ }
+
+ int64_t last_tablet_id = 0;
do {
- interval = config::tablet_path_check_interval_seconds;
int32_t batch_size = config::tablet_path_check_batch_size;
if (batch_size <= 0) {
if (_stop_background_threads_latch.wait_for(std::chrono::seconds(interval))) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org