You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simon Kitching <si...@ecnetwork.co.nz> on 2004/04/13 04:19:04 UTC

[digester] TO-DO for release 1.6

Hi,

Here's the list of things I think are remaining to do before a 1.6
release. I notice that the 1.5 release was done on 24-april-2003.
Wouldn't it be nice to get another release out before the year is up?

If there's anything that's not on this list, please speak up!

* resolve the "mixed content" issue [see later]
* prepare release notes
  I'm willing to do this if someone can give me some hints on the
  most efficient way to do this...
* double-check new method signatures [see later]
* confirm collections version compatibility [see later]
* add cvs-version info in somehow [see later]
* create and commit an xmlrules example to the examples directory.
* move rss stuff to "extras" directory
* test that all examples compile & run.
* find someone willing to be official release manager
* think about including proposed InvokeMethodRule [see later]
* prepare RC candidate, test, etc.

===
Re "mixed content":
* Justin, could you please post your proposed implementation either
  on this list, or attached to the bugzilla entry? Or have a look
  at my proposal and indicate whether that works for you?
* Craig, you were going to have a look at this, I believe? All
  comments welcome...
* Robert, you said in an email: "i have some possible concerns but i'll
  need to go through the proposed code". Can you spell out these
  concerns?

I'd be happy with a compromise on this feature. As the change has been
committed to keep a stack of matched rules, I *believe* that digester
subclasses can now override the startElement method to provide exactly
what my patch does. So maybe we can just document this approach
somewhere (eg by creating code in the examples subdir). I'll try to
implement this approach soon, and post the code if successful.

I think it would be nice in the long-term to provide "mixed content"
support without subclassing digester, but for now the subclassing seems
a reasonable solution.

Any opinions?

===
Re: double-check new method signatures

We should check that parameters and return values for all new methods
use the most abstract-possible types, eg return Map not HashMap where
appropriate, in order to avoid "lock-in" of concrete types. This also
applies to declared types for any protected class members.

===
Re: confirm collections version compatibility

It looks like the next digester release will still depend on
beanutils-1.6.1. However, I am not sure whether that means that digester
can be used with collections-3.0 or not. I suggest we run beanutils
1.6.1 tests with the collections-3.0 library, and also run the Digester
tests with beanutils 1.6.1 + collections 3.0. If all tests pass, then we
can declare that digester is compatible with both collections-2.1 and
collections-3.0, right?

===
Re: version info
Craig wants last-committed date and perhaps some other info in the
source files, for "disconnected" use. But maybe this does not need to be
in the javadoc? Would the same info in a non-javadoc comment meet the
requirements, eg like this?
  /**
   * class docs...
   */

  // last change: $.....$

  public class ..... {

This would remove what seems to me to be pointless info from the
javadoc, but still allow disconnected developers to see the last commit
info.

===
Re: InvokeMethodRule ("call method as soon as params are available")

I'm quite happy for this to wait until next release for consideration.

However, Emmanuel Bourg has requested this feature. And it may also be
useful for providing "immutable object support" in betwixt. So if anyone
out there feels strongly about including this feature in 1.6, then they
had better check out my proposal, and either approve it or propose
fixes/alternatives...


  
Phew!

No, really it doesn't look that bad. Only a couple of evenings' work, it
looks like to me, provided y'all are happy with this.

Craig, would you be willing to be the "official" release manager, ie
call the final release vote, sign the RC and final releases, etc.? If
not, is there someone you can blackmail into doing it??

And of course the more willing workers the better :-).

Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Craig McClanahan <cr...@apache.org>.
robert burrell donkin wrote:

>> * prepare release notes
>>   I'm willing to do this if someone can give me some hints on the
>>   most efficient way to do this...
>
>
> hehehe
>
> by tradition, digester uses criag's way of preparing release notes. 
> this means going through and collating the messages from each cvs 
> commit message and cross indexing them into features and bug fixes. 
> though a little labourious, it is a very good way of learning why good 
> cvs comments are important :)
>
> unfortunately, i do get a little lazy from time to time, so here's my 
> prior apologies. (i will give detail instructions on the mechanics if 
> you need them.)
>
> betwixt uses continuous addition. this works out well (and plays very 
> nicely with google) but does slow development. every feature is not 
> only added, unit tested but also written up and added to the list of 
> notes. both are good systems with different advantages.

If I were disciplined like Robert, I'd use continuous addition too :-).  
Unfortunately, I'm more a typical developer in this particular respect.

>
> - robert
>

Craig


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
> * prepare release notes
>   I'm willing to do this if someone can give me some hints on the
>   most efficient way to do this...

hehehe

by tradition, digester uses criag's way of preparing release notes. 
this means going through and collating the messages from each cvs 
commit message and cross indexing them into features and bug fixes. 
though a little labourious, it is a very good way of learning why good 
cvs comments are important :)

unfortunately, i do get a little lazy from time to time, so here's my 
prior apologies. (i will give detail instructions on the mechanics if 
you need them.)

betwixt uses continuous addition. this works out well (and plays very 
nicely with google) but does slow development. every feature is not 
only added, unit tested but also written up and added to the list of 
notes. both are good systems with different advantages.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 15 Apr 2004, at 01:40, Craig McClanahan wrote:
> robert burrell donkin wrote:
>> On 13 Apr 2004, at 03:19, Simon Kitching wrote:

<snip>

>>> Re: InvokeMethodRule ("call method as soon as params are available")
>>>
>>> I'm quite happy for this to wait until next release for 
>>> consideration.
>>>
>>> However, Emmanuel Bourg has requested this feature. And it may also 
>>> be
>>> useful for providing "immutable object support" in betwixt. So if 
>>> anyone
>>> out there feels strongly about including this feature in 1.6, then 
>>> they
>>> had better check out my proposal, and either approve it or propose
>>> fixes/alternatives...
>>
>>
>> +1
>>
> I will look at the proposal, and wouldn't mind the changes if they 
> look solid, but don't feel a burning desire for them myself.

(i'm not sure who's the more confused here ;)

i was trying to +1 the "let's not do anything about this for this 
release"...

>> once you know how to cut releases, let's quickly resolve this one and 
>> cut another release.
>>
> One additional issue was raised a while ago on the mailing list, and 
> again with me in personal mail; we ship the DTDs for the RSS formats 
> inside commons-digester.jar, but they have Netscape copyrights.  
> Although  the precedent of allowing DTDs with non-Apache copyrights 
> has been established elsewhere (W3C copyrights on some of the web 
> services DTDs), I don't think we really need to ship the RSS stuff 
> inside our JAR -- it's just a demo, after all.
>
> There was talk at one time about moving the RSS stuff out into a 
> src/examples directory, and packaging it in a separate JAR, but this 
> hasn't been done yet.  Anyone have a problem with me doing this 
> (probably late tonight)?

good catch craig :)

has anyone heard anything back from the board as to whether releases 
containing non-AL2.0 licensed material are still embargoed?

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Craig McClanahan <cr...@apache.org>.
Simon Kitching wrote:

>On Thu, 2004-04-15 at 12:40, Craig McClanahan wrote:
>  
>
>>One additional issue was raised a while ago on the mailing list, and 
>>again with me in personal mail; we ship the DTDs for the RSS formats 
>>inside commons-digester.jar, but they have Netscape copyrights.  
>>Although  the precedent of allowing DTDs with non-Apache copyrights has 
>>been established elsewhere (W3C copyrights on some of the web services 
>>DTDs), I don't think we really need to ship the RSS stuff inside our JAR 
>>-- it's just a demo, after all.
>>
>>There was talk at one time about moving the RSS stuff out into a 
>>src/examples directory, and packaging it in a separate JAR, but this 
>>hasn't been done yet.  Anyone have a problem with me doing this 
>>(probably late tonight)?
>>    
>>
>
>That sounds good to me. I presume you will be keeping the same package
>names for the rss code?
>
>  
>
That was my plan, so that any existing applications actually using it 
could just include the second JAR file as well.

>The examples stuff build approach is deliberately simple (just builds
>.class files inside the same dir as the source) to make it easy for
>users to then run the code. I don't know whether you'll want something
>more sophisticated for the rss stuff. 
>
>  
>
I'll probably make it mirror the way we build the core classes (into a 
separate directory under "target", for example).  That way, we can even 
set it up to have example-specific unit tests, if any ever exist.

>Last weekend I sent an email suggesting a "src/extras" directory for
>things which are more than "examples" but not core code, and starting
>extras off with the rss stuff. Ant has an "extras" jar for example. But
>I'm happy with rss being either in "src/examples" or "src/extras"
>whichever you prefer.
>
>  
>
I don't really think we need two addons .. it looks like 
"src/examples/rss" might be a good place for this set, because it's self 
contained and has enough classes that you wouldn't want to combine it.

>Regards,
>
>Simon
>
>  
>
Craig

>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Simon Kitching <si...@ecnetwork.co.nz>.
On Thu, 2004-04-15 at 12:40, Craig McClanahan wrote:
> >
> One additional issue was raised a while ago on the mailing list, and 
> again with me in personal mail; we ship the DTDs for the RSS formats 
> inside commons-digester.jar, but they have Netscape copyrights.  
> Although  the precedent of allowing DTDs with non-Apache copyrights has 
> been established elsewhere (W3C copyrights on some of the web services 
> DTDs), I don't think we really need to ship the RSS stuff inside our JAR 
> -- it's just a demo, after all.
> 
> There was talk at one time about moving the RSS stuff out into a 
> src/examples directory, and packaging it in a separate JAR, but this 
> hasn't been done yet.  Anyone have a problem with me doing this 
> (probably late tonight)?

That sounds good to me. I presume you will be keeping the same package
names for the rss code?

The examples stuff build approach is deliberately simple (just builds
.class files inside the same dir as the source) to make it easy for
users to then run the code. I don't know whether you'll want something
more sophisticated for the rss stuff. 

Last weekend I sent an email suggesting a "src/extras" directory for
things which are more than "examples" but not core code, and starting
extras off with the rss stuff. Ant has an "extras" jar for example. But
I'm happy with rss being either in "src/examples" or "src/extras"
whichever you prefer.

Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Craig McClanahan <cr...@apache.org>.
robert burrell donkin wrote:

> On 13 Apr 2004, at 03:19, Simon Kitching wrote:
>
> <snip>
>
> (mixed content in separate thread)
>
>> ===
>> Re: double-check new method signatures
>>
>> We should check that parameters and return values for all new methods
>> use the most abstract-possible types, eg return Map not HashMap where
>> appropriate, in order to avoid "lock-in" of concrete types. This also
>> applies to declared types for any protected class members.
>
>
> +1
>
> using jdiff is probably a good way to kick the process off.
>
Definitely +1.

>> ===
>> Re: confirm collections version compatibility
>>
>> It looks like the next digester release will still depend on
>> beanutils-1.6.1. However, I am not sure whether that means that digester
>> can be used with collections-3.0 or not. I suggest we run beanutils
>> 1.6.1 tests with the collections-3.0 library, and also run the Digester
>> tests with beanutils 1.6.1 + collections 3.0. If all tests pass, then we
>> can declare that digester is compatible with both collections-2.1 and
>> collections-3.0, right?
>
>
> that sounds like a good plan. i suspect that (after craig's changes), 
> there's a change that we'll be ok. it's a real shame that we made that 
> mistake in the beanutils interface. decoupling from collections could 
> be a real reason for pushing towards a beanutils 2.0 release.
>
We should be good to go with either ... even in [beanutils] the only 
dependency is on things that I don't think have changed.  We still have 
to test, of roucrse.

>> ===
>> Re: version info
>> Craig wants last-committed date and perhaps some other info in the
>> source files, for "disconnected" use. But maybe this does not need to be
>> in the javadoc? Would the same info in a non-javadoc comment meet the
>> requirements, eg like this?
>>   /**
>>    * class docs...
>>    */
>>
>>   // last change: $.....$
>>
>>   public class ..... {
>>
>> This would remove what seems to me to be pointless info from the
>> javadoc, but still allow disconnected developers to see the last commit
>> info.
>
>
> i'm happy with this plan but i'd say that the most usual place for 
> this is at the top of the file just above (or below) the license. good 
> since tags would be nice.
>
In a lot of code with the 1.x license, there was an "$Id$" line right at 
the top of the license comments, which I personaly found very convenient 
:-).

>> Re: InvokeMethodRule ("call method as soon as params are available")
>>
>> I'm quite happy for this to wait until next release for consideration.
>>
>> However, Emmanuel Bourg has requested this feature. And it may also be
>> useful for providing "immutable object support" in betwixt. So if anyone
>> out there feels strongly about including this feature in 1.6, then they
>> had better check out my proposal, and either approve it or propose
>> fixes/alternatives...
>
>
> +1
>
I will look at the proposal, and wouldn't mind the changes if they look 
solid, but don't feel a burning desire for them myself.

> once you know how to cut releases, let's quickly resolve this one and 
> cut another release.
>
One additional issue was raised a while ago on the mailing list, and 
again with me in personal mail; we ship the DTDs for the RSS formats 
inside commons-digester.jar, but they have Netscape copyrights.  
Although  the precedent of allowing DTDs with non-Apache copyrights has 
been established elsewhere (W3C copyrights on some of the web services 
DTDs), I don't think we really need to ship the RSS stuff inside our JAR 
-- it's just a demo, after all.

There was talk at one time about moving the RSS stuff out into a 
src/examples directory, and packaging it in a separate JAR, but this 
hasn't been done yet.  Anyone have a problem with me doing this 
(probably late tonight)?


> - robert
>

Craig


>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 13 Apr 2004, at 03:19, Simon Kitching wrote:

<snip>

(mixed content in separate thread)

> ===
> Re: double-check new method signatures
>
> We should check that parameters and return values for all new methods
> use the most abstract-possible types, eg return Map not HashMap where
> appropriate, in order to avoid "lock-in" of concrete types. This also
> applies to declared types for any protected class members.

+1

using jdiff is probably a good way to kick the process off.

> ===
> Re: confirm collections version compatibility
>
> It looks like the next digester release will still depend on
> beanutils-1.6.1. However, I am not sure whether that means that 
> digester
> can be used with collections-3.0 or not. I suggest we run beanutils
> 1.6.1 tests with the collections-3.0 library, and also run the Digester
> tests with beanutils 1.6.1 + collections 3.0. If all tests pass, then 
> we
> can declare that digester is compatible with both collections-2.1 and
> collections-3.0, right?

that sounds like a good plan. i suspect that (after craig's changes), 
there's a change that we'll be ok. it's a real shame that we made that 
mistake in the beanutils interface. decoupling from collections could 
be a real reason for pushing towards a beanutils 2.0 release.

> ===
> Re: version info
> Craig wants last-committed date and perhaps some other info in the
> source files, for "disconnected" use. But maybe this does not need to 
> be
> in the javadoc? Would the same info in a non-javadoc comment meet the
> requirements, eg like this?
>   /**
>    * class docs...
>    */
>
>   // last change: $.....$
>
>   public class ..... {
>
> This would remove what seems to me to be pointless info from the
> javadoc, but still allow disconnected developers to see the last commit
> info.

i'm happy with this plan but i'd say that the most usual place for this 
is at the top of the file just above (or below) the license. good since 
tags would be nice.

> Re: InvokeMethodRule ("call method as soon as params are available")
>
> I'm quite happy for this to wait until next release for consideration.
>
> However, Emmanuel Bourg has requested this feature. And it may also be
> useful for providing "immutable object support" in betwixt. So if 
> anyone
> out there feels strongly about including this feature in 1.6, then they
> had better check out my proposal, and either approve it or propose
> fixes/alternatives...

+1

once you know how to cut releases, let's quickly resolve this one and 
cut another release.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 4 May 2004, at 23:26, Simon Kitching wrote:

> On Wed, 2004-05-05 at 09:25, robert burrell donkin wrote:
>> On 24 Apr 2004, at 04:12, Craig R. McClanahan wrote:
>>> Simon Kitching wrote:
>>
>> <snip>
>>
>>>>  * move rss stuff to "extras" directory
>>> -- will take care of this over the weekend.
>>
>> i'm happy to do the actual moving. IMHO the real question is about
>> what's the best structure.
>>
>> digester -- src -- java
>>           |      |
>>           |      |- test
>>           |
>>           |- extras -- rss -- src -- java
>>                                   |
>>                                   |- test
>>
>> is this the kind of thing people are thinking about?
>>
>> anyone have any comments/alternatives?
>
> That's pretty much what I was thinking, though I thought we could
> simplify things and just have a single "extras" directory for
> everything, ie
>    digester/src/extras/src/java/org/apache/commons/digester/rss
>
> However Craig didn't like the "extras" idea when I suggested it, and
> preferred to put RSS under "examples" (which is also fine by me). He 
> has
> now done this: see
>    digester/src/examples/rss/src/java/....

there are a couple of reasons why i prefer a separate sub-directory:

1 i would like to be able to add extensions of core digester code that 
add non-core dependencies. it seemed natural to me to include both the 
rss code and this new code under extras.

2 maven plays a little better with subdirectories.

(but i don't think that it makes a lot of difference)

the only pressing issue about the rss code is that some of the struts 
documentation depends on it.

> I can't see any rss unit tests. I thought there were some before, but I
> can't find any now, even when updating with -D to check old stuff.
> DigesterTestCase has a few DTD declarations for rss, but that's all I
> can see.

IMO viewCVS is very good at tracking down stuff like this.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Simon Kitching <si...@ecnetwork.co.nz>.
On Wed, 2004-05-05 at 09:25, robert burrell donkin wrote:
> On 24 Apr 2004, at 04:12, Craig R. McClanahan wrote:
> > Simon Kitching wrote:
> 
> <snip>
> 
> >>  * move rss stuff to "extras" directory
> > -- will take care of this over the weekend.
> 
> i'm happy to do the actual moving. IMHO the real question is about 
> what's the best structure.
> 
> digester -- src -- java
>           |      |
>           |      |- test
>           |
>           |- extras -- rss -- src -- java
>                                   |
>                                   |- test
> 
> is this the kind of thing people are thinking about?
> 
> anyone have any comments/alternatives?

That's pretty much what I was thinking, though I thought we could
simplify things and just have a single "extras" directory for
everything, ie
   digester/src/extras/src/java/org/apache/commons/digester/rss

However Craig didn't like the "extras" idea when I suggested it, and
preferred to put RSS under "examples" (which is also fine by me). He has
now done this: see
   digester/src/examples/rss/src/java/....

I can't see any rss unit tests. I thought there were some before, but I
can't find any now, even when updating with -D to check old stuff.
DigesterTestCase has a few DTD declarations for rss, but that's all I
can see.

Regards,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 24 Apr 2004, at 04:12, Craig R. McClanahan wrote:
> Simon Kitching wrote:

<snip>

>>  * move rss stuff to "extras" directory
>>>
>> Craig?
>>
>
> Sorry ... I've been totally buried with day-job responsibilities 
> lately -- check out Sun Java Studio Creator if you want to know what 
> I'm currently working on :-)

cool :)

> -- will take care of this over the weekend.

i'm happy to do the actual moving. IMHO the real question is about 
what's the best structure.

digester -- src -- java
          |      |
          |      |- test
          |
          |- extras -- rss -- src -- java
                                  |
                                  |- test

is this the kind of thing people are thinking about?

anyone have any comments/alternatives?

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by "Craig R. McClanahan" <cr...@apache.org>.
Arnaud Heritier wrote:

>>>Craig?
>>>
>>>
>>>      
>>>
>>Sorry ... I've been totally buried with day-job responsibilities lately
>>-- check out Sun Java Studio Creator if you want to know what I'm
>>currently working on :-) -- will take care of this over the weekend.
>>    
>>
>
>It's very interesting Craig.
>Do you think that JSC will support struts (creating navigation graphs like
>in websphere or weblogic)??
>  
>
Not in 1.0 (although Creator does support graphical navigation maps for 
the navigation handler technology in JavaServer Faces directly).  After 
that, we'll see....

Craig


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


RE: [digester] TO-DO for release 1.6

Posted by Arnaud Heritier <ar...@laposte.net>.
> >Craig?
> >
> >
> 
> Sorry ... I've been totally buried with day-job responsibilities lately
> -- check out Sun Java Studio Creator if you want to know what I'm
> currently working on :-) -- will take care of this over the weekend.

It's very interesting Craig.
Do you think that JSC will support struts (creating navigation graphs like
in websphere or weblogic)??

Arnaud.



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by "Craig R. McClanahan" <cr...@apache.org>.
Simon Kitching wrote:

>On Tue, 2004-04-13 at 14:19, Simon Kitching wrote:
>  
>
>>Hi,
>>
>>Here's the list of things I think are remaining to do before a 1.6
>>release. I notice that the 1.5 release was done on 24-april-2003.
>>Wouldn't it be nice to get another release out before the year is up?
>>    
>>
>
>  
>
>>* resolve the "mixed content" issue [see later]
>>    
>>
>Done. Example added to cvs.
>
>  
>
>>* prepare release notes
>>    
>>
>Draft done and committed to CVS. The changes were compiled with the 
>help of jdiff and a log of "cvs log" and "cvs diff" work :-)
>
>  
>
>>* double-check new method signatures [see later]
>>    
>>
>Done. No issues were found.
>
>  
>
>>* confirm collections version compatibility [see later]
>>    
>>
>Done. Collections 3.0 works fine.
>
>  
>
>>* create and commit an xmlrules example to the examples directory.
>>    
>>
>Done. 
>
>  
>
>>* test that all examples compile & run.
>>    
>>
>Done.
>
>  
>
>>* think about including proposed InvokeMethodRule [see later]
>>    
>>
>Done. Will be postponed until next release.
>
>===========================
>
>So, on to the still-to-do list:
>
>* add cvs-version info in somehow [see later]
>After reviewing Robert and Craig's emails, it seems that there is a
>preference there for the version info to be higher up - maybe even
>within the copyright comments at the top of the file. Is this allowed?
>If so, can we run with it? I'm happy with this, though I do think my
>(admittedly slightly unusual) suggestion of putting it on the *last*
>line of the file also has merit. Maybe just too unexpected, though.
>  
>
I don't see any problem with putting a CVS comment line above the 
license text at the top of the file.  My personal preference is:

  /* $Id$
   *
   * ... the standard license text goes here ...
   */

so that a "head -1" lists the id strings, but that's just me.

>  
>
>>* move rss stuff to "extras" directory
>>    
>>
>Craig?
>  
>

Sorry ... I've been totally buried with day-job responsibilities lately 
-- check out Sun Java Studio Creator if you want to know what I'm 
currently working on :-) -- will take care of this over the weekend.

>  
>
>>* find someone willing to be official release manager
>>    
>>
>Anyone?????
>  
>
If it were after JavaOne I'd do this in a shot ... unfortunately, it's 
not yet :-(.

>  
>
>>* prepare RC candidate, test, etc.
>>    
>>
>Yep.
>
>Also:
>* run checkstyle?
>* check there is a "src" distribution, and that it includes the examples
>* set up wiki for digester, add ref from digester website to it.
>* check code with java1.2 SDK (this is the minimum java version, right?)
>* Robert's changes to logging?
>* put in some more @since tags?
>* finishing touches to release notes.
>  
>

Thanks for all the awesome work, Simon!

>Cheers,
>
>Simon
>  
>
Craig




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Simon Kitching <si...@ecnetwork.co.nz>.
On Tue, 2004-04-13 at 14:19, Simon Kitching wrote:
> Hi,
> 
> Here's the list of things I think are remaining to do before a 1.6
> release. I notice that the 1.5 release was done on 24-april-2003.
> Wouldn't it be nice to get another release out before the year is up?

> * resolve the "mixed content" issue [see later]
Done. Example added to cvs.

> * prepare release notes
Draft done and committed to CVS. The changes were compiled with the 
help of jdiff and a log of "cvs log" and "cvs diff" work :-)

> * double-check new method signatures [see later]
Done. No issues were found.

> * confirm collections version compatibility [see later]
Done. Collections 3.0 works fine.

> * create and commit an xmlrules example to the examples directory.
Done. 

> * test that all examples compile & run.
Done.

> * think about including proposed InvokeMethodRule [see later]
Done. Will be postponed until next release.

===========================

So, on to the still-to-do list:

* add cvs-version info in somehow [see later]
After reviewing Robert and Craig's emails, it seems that there is a
preference there for the version info to be higher up - maybe even
within the copyright comments at the top of the file. Is this allowed?
If so, can we run with it? I'm happy with this, though I do think my
(admittedly slightly unusual) suggestion of putting it on the *last*
line of the file also has merit. Maybe just too unexpected, though.

> * move rss stuff to "extras" directory
Craig?

> * find someone willing to be official release manager
Anyone?????

> * prepare RC candidate, test, etc.
Yep.

Also:
* run checkstyle?
* check there is a "src" distribution, and that it includes the examples
* set up wiki for digester, add ref from digester website to it.
* check code with java1.2 SDK (this is the minimum java version, right?)
* Robert's changes to logging?
* put in some more @since tags?
* finishing touches to release notes.

Cheers,

Simon



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Simon Kitching <si...@ecnetwork.co.nz>.
On Wed, 2004-04-14 at 12:33, Simon Kitching wrote:
> On Wed, 2004-04-14 at 10:09, robert burrell donkin wrote:
> > i've been thinking about LogUtils. 
> 
> Despite all the above, if you have something in mind which is an
> improvement on the current logging approach for digester, even if it
> doesn't meet 100% of the above requirements then that would be cool. I
> look forward to seeing your patch.

Hi Robert,

I hope the above doesn't sound too "abrupt". I'm not trying to "take
over" digester design! I just mean that I personally don't see any way
for a solution which is a layer "above" commons-logging to 100% satisfy
what I believe are the requirements. I could always be wrong, and really
*am* interested in seeing what you want to do with LogUtils.

Cheers,

Simon



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by Simon Kitching <si...@ecnetwork.co.nz>.
On Wed, 2004-04-14 at 10:09, robert burrell donkin wrote:
> i've been thinking about LogUtils. often, improved factoring of the 
> code allows further improvements. i'd prefer to allow the user more 
> flexibility in their choice of logging and i'd like to add this before 
> the 1.6 release (which i assume includes the refactored plugin stuff).
> 
> i think that we can preserve the default behaviour by calling the 
> plugin context to provide the log implementation. if we get the 
> signature right, it should be possible to allow per-class logging (as 
> an option). we may need to consider whether it would be better to 
> factor out a separate log provider class exposed by a property or just 
> add the call to the context (and then expect users to subclass).
> 
> if this sounds a good plan (and you don't fancy implementing it 
> yourself), let me know and i'll post a patch tomorrow.

Please go ahead. I'll look for your patch later.

However here are what I think the requirements are for a *real* solution
to digester logging:

* There should be no performance penalty for "normal" users, ie the
  99.999% of them that don't redirect logging on a per-digester basis.
* Code should always log using a category that matches the logging
  class name. Under normal use, the underlying logging framework should
  be told the correct category so it can correctly filter. Under
  "redirected" logging, it is desirable for the underlying framework to
  be told the correct category but if a solution can be found that ends
  up "losing" this info, I would be happy, as I don't really care if
  "redirected" logging is actually useable or not. 
* Code should be able to declare
      private static Log log = LogFactory.getLog(this.class);
  because this is much more efficient than retrieving the logger by
  category name each time. 
* Code should be able to log even when it doesn't have a reference to
  a digester object (or a PluginContext object or whatever). This allows
  classes to log *before* they have an associated digester object, and
  means that classes which *never* have an explicit reference to their
  associated digester can still log.
* When Digester code calls into BeanUtils, and BeanUtils outputs a log
  message, that message should also be redirected to whatever 
  destination the calling digester instance logging is being sent to.
* When Digester code calls into user-written rules and they log, that
  message should also be redirected to whatever destination the
  calling digester instance logging is being sent to.

The current logging approach of Digester fails every one of the above.

I believe the only solution that satisfies all the above involves
writing custom commons-logging LogFactory/Log classes, and redirecting
the logging at that level in a manner which makes the logging
redirection totally transparent to the calling code. Normal code just
uses standard commons-logging, so gets standard behaviour. Code that
wants redirection sets up commons-logging with the custom LogFactory
etc. And if it's totally transparent to the logging code, then the
problem has been solved without any "LogUtils" module so any work done
now on "LogUtils" classes or similar becomes obsolete.

I spent a full day recently experimenting with common-logging, and made
some progress. But a lot more time needs to be spent on this to get the
commons-logging-based solution right, and I would prefer to do that in
the 1.7 cycle rather than tackle it for 1.6. Of course someone more
familiar with commons-logging than me could possibly solve it faster.


Despite all the above, if you have something in mind which is an
improvement on the current logging approach for digester, even if it
doesn't meet 100% of the above requirements then that would be cool. I
look forward to seeing your patch.


Cheers,

Simon


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [digester] TO-DO for release 1.6

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
this looks pretty comprehensive :)

i hope to set some time aside tomorrow to go through it in detail.

i've been thinking about LogUtils. often, improved factoring of the 
code allows further improvements. i'd prefer to allow the user more 
flexibility in their choice of logging and i'd like to add this before 
the 1.6 release (which i assume includes the refactored plugin stuff).

i think that we can preserve the default behaviour by calling the 
plugin context to provide the log implementation. if we get the 
signature right, it should be possible to allow per-class logging (as 
an option). we may need to consider whether it would be better to 
factor out a separate log provider class exposed by a property or just 
add the call to the context (and then expect users to subclass).

if this sounds a good plan (and you don't fancy implementing it 
yourself), let me know and i'll post a patch tomorrow.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


mixed content release issues [WAS Re: [digester] TO-DO for release 1.6]

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 13 Apr 2004, at 03:19, Simon Kitching wrote:
> Re "mixed content":
> * Justin, could you please post your proposed implementation either
>   on this list, or attached to the bugzilla entry? Or have a look
>   at my proposal and indicate whether that works for you?
> * Craig, you were going to have a look at this, I believe? All
>   comments welcome...
> * Robert, you said in an email: "i have some possible concerns but i'll
>   need to go through the proposed code". Can you spell out these
>   concerns?
>
> I'd be happy with a compromise on this feature. As the change has been
> committed to keep a stack of matched rules, I *believe* that digester
> subclasses can now override the startElement method to provide exactly
> what my patch does. So maybe we can just document this approach
> somewhere (eg by creating code in the examples subdir). I'll try to
> implement this approach soon, and post the code if successful.
>
> I think it would be nice in the long-term to provide "mixed content"
> support without subclassing digester, but for now the subclassing seems
> a reasonable solution.
>
> Any opinions?

documentation plus an example would be a good way to postpone the 
issue. it may be easier to decide on this after the release. it's 
probably not a big a priority (for me) as logging but maybe i'll round 
to it before the release happens.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org