You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/19 10:26:33 UTC
[GitHub] [pulsar] kaja78 opened a new pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
kaja78 opened a new pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893
Fixes #12880
### Motivation
Override original Pulsar topic name by topic config property.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
Changes (fixes) default behaviour of KafkaConnectSink and its descendants.
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-1052936714
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-973970990
@kaja78:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-979224642
@dlg99 Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaja78 commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
kaja78 commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-974044208
I believe the docs needs not to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kaja78 commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
kaja78 commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-977908284
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12893: [issue 12880][kafka-connect-adaptor] Override original Pulsar topic name by topic config property
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12893:
URL: https://github.com/apache/pulsar/pull/12893#issuecomment-975002014
@kaja78 when submitting a PR, can you help provide a doc label (tick the box) in the [PR template which contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation)? This helps others know more about the changes. Thanks
<img width="682" alt="Documentation" src="https://user-images.githubusercontent.com/50226895/142789807-5772199c-6bc7-455b-9517-9c981bf35d4a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org