You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "wecharyu (via GitHub)" <gi...@apache.org> on 2023/07/08 05:39:29 UTC

[GitHub] [hive] wecharyu commented on a diff in pull request #4455: HIVE-27469: HMSHandler lost root cause of MetaStorePreEventListener

wecharyu commented on code in PR #4455:
URL: https://github.com/apache/hive/pull/4455#discussion_r1257044072


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -3957,10 +3957,10 @@ private void firePreEvent(PreEventContext event) throws MetaException {
     for (MetaStorePreEventListener listener : preListeners) {
       try {
         listener.onEvent(event);
-      } catch (NoSuchObjectException e) {
-        throw new MetaException(e.getMessage());
-      } catch (InvalidOperationException e) {
-        throw new MetaException(e.getMessage());
+      } catch (NoSuchObjectException | InvalidOperationException e) {
+        MetaException me = new MetaException(e.getMessage());

Review Comment:
   `HiveMetaException` seems not be used in `HMSHandler`, please kindly correct me if I misunderstood.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org