[GitHub] [airflow] milton0825 commented on a change in pull request #5141: [AIRFLOW-4362] Fix test_execution_limited_parallelism

[GitBox <gi...@apache.org>]

milton0825 commented on a change in pull request #5141: [AIRFLOW-4362] Fix test_execution_limited_parallelism
URL: https://github.com/apache/airflow/pull/5141#discussion_r277135637
 
 

 ##########
 File path: tests/executors/test_local_executor.py
 ##########
 @@ -55,14 +55,16 @@ def execution_parallelism(self, parallelism=0):
         else:
             executor.end()
 
-        for i in range(self.TEST_SUCCESS_COMMANDS):
-            key = success_key.format(i)
-            self.assertTrue(executor.event_buffer[key], State.SUCCESS)
-        self.assertTrue(executor.event_buffer['fail'], State.FAILED)
+        if isinstance(executor.impl, LocalExecutor._LimitedParallelism):
 
 Review comment:
   So when `executor.end()`is called, it ensures that the queues are empty with:
   https://github.com/apache/airflow/blob/master/airflow/executors/local_executor.py#L195-L196
   https://github.com/apache/airflow/blob/master/airflow/executors/local_executor.py#L205
   
   So I am adding assertion in the test to ensure that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services