You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/03/02 16:06:50 UTC

[GitHub] [fluo] keith-turner commented on a change in pull request #1087: Add Oracle count functionality

keith-turner commented on a change in pull request #1087: Add Oracle count functionality
URL: https://github.com/apache/fluo/pull/1087#discussion_r386486954
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
 ##########
 @@ -516,6 +517,23 @@ public boolean oracleExists() {
     return oracleExists(getAppCurator());
   }
 
+  public static int numOracles(CuratorFramework curator) {
 
 Review comment:
   Seems like this method is only called in one place and could be inlined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services