You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/02/06 02:54:33 UTC
Review Request 65518: Reaped the container process directly in Docker
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Vinod Kone.
Bugs: MESOS-8488
https://issues.apache.org/jira/browse/MESOS-8488
Repository: mesos
Description
-------
Due to a Docker issue (https://github.com/moby/moby/issues/33820),
Docker daemon will fail to catch a container exit, i.e., the container
process has already exited but the command `docker ps` shows the
container still running, this will lead to the "docker run" command
that we execute in Docker executor never returns, and it will also
cause the `docker stop` command takes no effect, i.e., it will return
without error but `docker ps` shows the container still running, so
the task will stuck in `TASK_KILLING` state.
To workaround this Docker issue, in this patch we made Docker executor
reaps the container process directly so Docker executor will be notified
once the container process exits.
Diffs
-----
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65518/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 65518: Reaped the container process directly in
Docker executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/#review196893
-----------------------------------------------------------
PASS: Mesos patch 65518 was successfully built and tested.
Reviews applied: `['65518']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65518
- Mesos Reviewbot Windows
On Feb. 6, 2018, 1:45 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65518/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 1:45 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-8488
> https://issues.apache.org/jira/browse/MESOS-8488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to a Docker issue (https://github.com/moby/moby/issues/33820),
> Docker daemon will fail to catch a container exit, i.e., the container
> process has already exited but the command `docker ps` shows the
> container still running, this will lead to the "docker run" command
> that we execute in Docker executor never returns, and it will also
> cause the `docker stop` command takes no effect, i.e., it will return
> without error but `docker ps` shows the container still running, so
> the task will stuck in `TASK_KILLING` state.
>
> To workaround this Docker issue, in this patch we made Docker executor
> reaps the container process directly so Docker executor will be notified
> once the container process exits.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65518/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65518: Reaped the container process directly in
Docker executor.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/
-----------------------------------------------------------
(Updated Feb. 6, 2018, 9:45 p.m.)
Review request for mesos, Greg Mann and Vinod Kone.
Changes
-------
Replaced `onAny` with `then`.
Bugs: MESOS-8488
https://issues.apache.org/jira/browse/MESOS-8488
Repository: mesos
Description
-------
Due to a Docker issue (https://github.com/moby/moby/issues/33820),
Docker daemon will fail to catch a container exit, i.e., the container
process has already exited but the command `docker ps` shows the
container still running, this will lead to the "docker run" command
that we execute in Docker executor never returns, and it will also
cause the `docker stop` command takes no effect, i.e., it will return
without error but `docker ps` shows the container still running, so
the task will stuck in `TASK_KILLING` state.
To workaround this Docker issue, in this patch we made Docker executor
reaps the container process directly so Docker executor will be notified
once the container process exits.
Diffs (updated)
-----
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65518/diff/2/
Changes: https://reviews.apache.org/r/65518/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 65518: Reaped the container process directly in
Docker executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/#review196862
-----------------------------------------------------------
PASS: Mesos patch 65518 was successfully built and tested.
Reviews applied: `['65518']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65518
- Mesos Reviewbot Windows
On Feb. 5, 2018, 6:54 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65518/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 6:54 p.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-8488
> https://issues.apache.org/jira/browse/MESOS-8488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to a Docker issue (https://github.com/moby/moby/issues/33820),
> Docker daemon will fail to catch a container exit, i.e., the container
> process has already exited but the command `docker ps` shows the
> container still running, this will lead to the "docker run" command
> that we execute in Docker executor never returns, and it will also
> cause the `docker stop` command takes no effect, i.e., it will return
> without error but `docker ps` shows the container still running, so
> the task will stuck in `TASK_KILLING` state.
>
> To workaround this Docker issue, in this patch we made Docker executor
> reaps the container process directly so Docker executor will be notified
> once the container process exits.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65518/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>