You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 04:21:30 UTC

[GitHub] [camel-website] AemieJ opened a new pull request #231: CAMEL-14732: Position footer to be at the bottom of the page

AemieJ opened a new pull request #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231
 
 
   * It has been observed that for certain pages where the content is minimal, the footer is not fixed to the bottom of the page in the desktop version. 
   
   * Thus, I changed the code such that the footer will remain on the bottom of the page regardless of the minimal text on each webpage.
   
   ![Issue: Footer doesn't remain on the bottom of the page](https://user-images.githubusercontent.com/44139348/76924897-cfc48980-68fd-11ea-8ead-ae7c9a24e38f.png)
   
   ![Solution: Changed margin such that footer remain on the bottom of the page]()
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#issuecomment-603189362
 
 
   I don't think this solves the issue, here's an example:
   ![Screenshot_2020-03-24 Tooling - Apache Camel](https://user-images.githubusercontent.com/1306050/77421442-26353a80-6dcc-11ea-8f9e-6bfec9e0a15e.png)
   
   This is at 1920x1080 on https://builds.apache.org/job/Camel.website/job/PR-231/Preview/categories/Tooling/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#issuecomment-603193217
 
 
   I will try resolving it permanently irrespective of the browser size then. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#issuecomment-602491683
 
 
   Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-231/Preview/index.html)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ edited a comment on issue #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#issuecomment-602500104
 
 
   > Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-231/Preview/index.html)
   
   Yes, we could use **rem** instead of **em**. I saw the preview, it works and I committed those changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ closed pull request #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
AemieJ closed pull request #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#issuecomment-602500104
 
 
   > Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-231/Preview/index.html)
   
   Yes, we could use `rem` instead of `em`. I saw the preview, it works and I committed those changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on a change in pull request #231: CAMEL-14732: Position footer to be at the bottom of the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #231: CAMEL-14732: Position footer to be at the bottom of the page
URL: https://github.com/apache/camel-website/pull/231#discussion_r396326911
 
 

 ##########
 File path: antora-ui-camel/src/css/footer.css
 ##########
 @@ -64,7 +65,10 @@ footer .footer dl dd {
 
 .edit {
   max-width: var(--static-max-width--desktop);
-  margin: auto;
+  position: relative;
+  margin-top: 10em;
 
 Review comment:
   Perhaps we could use `rem` here?
   
   ```suggestion
     margin-top: 10rem;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services