You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 20:19:00 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #8609: ARROW-10513: [Rust]: ARMv7 compilation

nevi-me commented on a change in pull request #8609:
URL: https://github.com/apache/arrow/pull/8609#discussion_r520092924



##########
File path: rust/arrow/src/array/union.rs
##########
@@ -698,7 +699,11 @@ mod tests {
             4 * 8 * 4 * mem::size_of::<i32>(),
             union.get_buffer_memory_size()
         );
-        let internals_of_union_array = (8 + 72) + (union.boxed_fields.len() * 144); // Arc<ArrayData> & Vec<ArrayRef> combined.
+        let tagged_pointer_size = POINTER_WIDTH / 4 + POINTER_WIDTH;
+        let internals_of_union_array = tagged_pointer_size

Review comment:
       I struggled to follow the arithmetic here, but perhaps I need to look at the spec again




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org