[GitHub] [arrow-rs] alamb commented on issue #563: Add a compute comparator interface that doesn't bind array instances

[GitBox <gi...@apache.org>]

alamb commented on issue #563:
URL: https://github.com/apache/arrow-rs/issues/563#issuecomment-890497670


   While looking through the hash join code from @Dandandan  in DataFusion, I found another implementation of a comparator that is similar to the comparator interface proposed in this PR. It is called `equal_rows` and could potentially benefit from not dispatching on the type (to then have to downcast as well) on each comparison
   
   ```rust
   /// Left and right row have equal values
   fn equal_rows(
       left: usize,
       right: usize,
       left_arrays: &[ArrayRef],
       right_arrays: &[ArrayRef],
   ) -> Result<bool> {
   ```
   
   https://github.com/apache/arrow-datafusion/blob/18c581c4dbfbc3b5d135b3bc0d1cdb5c16af9c78/datafusion/src/physical_plan/hash_join.rs#L813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org