You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aikawa-ohno (via GitHub)" <gi...@apache.org> on 2026/07/13 02:10:25 UTC

[PR] fix(i18n): Update Japanese translations [superset]

aikawa-ohno opened a new pull request, #41984:
URL: https://github.com/apache/superset/pull/41984

   ・I translated what hadn't been translated.
   ・I have corrected the errors in the content.
   ・I asked the AI to make revisions with a focus on consistency and clarity, and incorporated only the parts that seemed appropriate.
   
   ### ADDITIONAL INFORMATION
   - [x] Changes UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4976722826

   Thanks @aikawa-ohno, the Japanese translations here look like solid work, and clearing out the fuzzy flags and the old `# Machine-translated via backfill_po.py` comments is exactly the right direction.
   
   One thing before we can merge though: the file currently fails `msgfmt -c`. Un-fuzzying the `%(suggestion)s instead of...` plural entry left a `msgstr[0]` that's missing a couple of the plural placeholders, and there's a malformed `#,python-format` flag (missing the space) snuck in too.
   
   Easiest path is to rebase on current `master` (it's conflicting right now anyway) and run `scripts/translations/babel_update.sh`, then commit the result. That'll clean up the flag spacing and sort out the `% calculation` / `% of parent` / `% of total` entries automatically.
   
   The codeant bot comment about `msgstr[1]` doesn't apply here, so safe to ignore that one. Holler if you want a hand with the rebase!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #41984:
URL: https://github.com/apache/superset/pull/41984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41984:
URL: https://github.com/apache/superset/pull/41984#discussion_r3584417027


##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -16204,6 +15775,8 @@ msgid ""
 "You need access to the following tables: %(tables)s, "
 "'all_database_access' or 'all_datasource_access' permission"
 msgstr ""
+"テーブルへの以下のアクセス権が必要です:%(tables)s"
+"(「all_database_access」または「all_datasource_access)"

Review Comment:
   **Suggestion:** The translated message is truncated and has unbalanced punctuation/quotes, which will render a broken user-facing permission error and hide part of the original instruction. Complete the sentence and fix the unmatched quote/parenthesis so the message faithfully conveys both required permissions. [typo]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   ⚠️ Japanese users see broken table-permission error message.
   ⚠️ Guidance on required permissions truncated and unclear.
   ⚠️ Security denial message harder for admins to interpret.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. In `superset/security/manager.py:1788-1815`, note `get_table_access_error_msg()` builds
   a translated error message via `_()` using msgid `"You need access to the following
   tables: %(tables)s, 'all_database_access' or 'all_datasource_access' permission"` and
   returns it to `get_table_access_error_object()` which is used in `raise
   SupersetSecurityException(...)` at `manager.py:3863`.
   
   2. In the Japanese catalog `superset/translations/ja/LC_MESSAGES/messages.po` around lines
   15778-15779 (verified via grep/read), the `msgstr` for that msgid is split across two
   lines as `"テーブルへの以下のアクセス権が必要です:%(tables)s"` and
   `"(「all_database_access」または「all_datasource_access)"`, leaving the closing Japanese
   quote/parenthesis and the final “permission” portion missing.
   
   3. Run Superset with `LANG=ja` (Japanese locale) and connect a user that lacks table
   permissions so `get_table_access_error_object()` is triggered (for example, open SQL Lab,
   run a query that references a table the user cannot access, causing `denied` to be
   non-empty and `raise
   SupersetSecurityException(self.get_table_access_error_object(denied))` at
   `manager.py:3858-3867`).
   
   4. Observe the user-facing error text in the Japanese UI: the message is truncated after
   the table list, followed by a dangling
   `"(「all_database_access」または「all_datasource_access)"` fragment with unmatched closing
   quote/parenthesis and missing context about required permissions, confirming a broken and
   incomplete permission error caused by the current `msgstr` formatting.
   ```
   </details>
   
   [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a3e7e9bfa5a04f43a7d6c7530e9e9046&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a3e7e9bfa5a04f43a7d6c7530e9e9046&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/translations/ja/LC_MESSAGES/messages.po
   **Line:** 15778:15779
   **Comment:**
   	*Typo: The translated message is truncated and has unbalanced punctuation/quotes, which will render a broken user-facing permission error and hide part of the original instruction. Complete the sentence and fix the unmatched quote/parenthesis so the message faithfully conveys both required permissions.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41984&comment_hash=74c7da4d8df19f3d1d35b9cd0a9a1581494446fe4b1a85ef9877ca8f51720b91&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41984&comment_hash=74c7da4d8df19f3d1d35b9cd0a9a1581494446fe4b1a85ef9877ca8f51720b91&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41984:
URL: https://github.com/apache/superset/pull/41984#discussion_r3567681071


##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -245,12 +254,13 @@ msgstr ""
 msgid "%(rows)d rows returned"
 msgstr "%(rows)d 行が返されました"
 
-#, fuzzy, python-format
+#, python-format
 msgid "%(suggestion)s instead of \"%(undefinedParameter)s?\""
 msgid_plural ""
 "%(firstSuggestions)s or %(lastSuggestion)s instead of "
 "\"%(undefinedParameter)s\"?"
 msgstr[0] "「%(undefinedParameter)s」の代わりに「%(suggestion)s」を使用しますか?"
+msgstr[1] "「%(undefinedParameter)s」の代わりに「%(firstSuggestions)s」または「%(lastSuggestion)s」を使用しますか?"

Review Comment:
   **Suggestion:** Japanese is configured with `nplurals=1`, so adding `msgstr[1]` creates an invalid plural-form mapping for this catalog. Keep only `msgstr[0]` for this entry; otherwise gettext compilation/validation can fail or ignore the extra translation index inconsistently. [api mismatch]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Backend translation compile may warn or fail for ja catalog.
   - ⚠️ Japanese plural suggestion string has unused/invalid extra form.
   - ⚠️ i18n build pipeline may see inconsistent plural configuration.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Open the Japanese catalog at `superset/translations/ja/LC_MESSAGES/messages.po` and
   inspect the header; at line 15 (verified via Read) the `Plural-Forms` entry is
   `Plural-Forms: nplurals=1; plural=0;`, meaning this locale is configured to have exactly
   one plural form.
   
   2. In the same file, navigate to the pluralized suggestion string around lines 8–14 in the
   snippet shown by Read; there you can see the entry:
   
      - `msgid "%(suggestion)s instead of \"%(undefinedParameter)s?\""`
   
      - `msgid_plural "%(firstSuggestions)s or %(lastSuggestion)s instead of
      \"%(undefinedParameter)s\"?"`
   
      - `msgstr[0] "「%(undefinedParameter)s」の代わりに「%(suggestion)s」を使用しますか?"`
   
      - `msgstr[1]
      "「%(undefinedParameter)s」の代わりに「%(firstSuggestions)s」または「%(lastSuggestion)s」を使用しますか?"`
      (line 263 in the PR diff).
   
   3. Consult the translation workflow in `docs/developer_docs/contributing/howtos.md` lines
   31–37 (verified via Read), which instruct running `pybabel compile --use-fuzzy -d
   superset/translations` to compile all `.po` catalogs into `.mo` files for backend
   translations; this command will process `messages.po` for Japanese along with other
   locales.
   
   4. When `pybabel compile` reads the Japanese catalog with `nplurals=1` but finds two
   plural translations (`msgstr[0]` and `msgstr[1]`) for the same `msgid_plural`, the
   plural-form mapping is inconsistent: only indices 0..(nplurals-1) are valid. Depending on
   the exact gettext/Babel behavior, this results in compilation warnings or errors for the
   `ja` catalog and the extra `msgstr[1]` being ignored, making that additional Japanese
   translation unused and potentially failing CI or local translation builds that expect
   clean catalogs.
   ```
   </details>
   
   [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=27fb118013644c5387022d042d15f37b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=27fb118013644c5387022d042d15f37b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/translations/ja/LC_MESSAGES/messages.po
   **Line:** 263:263
   **Comment:**
   	*Api Mismatch: Japanese is configured with `nplurals=1`, so adding `msgstr[1]` creates an invalid plural-form mapping for this catalog. Keep only `msgstr[0]` for this entry; otherwise gettext compilation/validation can fail or ignore the extra translation index inconsistently.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41984&comment_hash=0cb0ea9ecd79236f5e59b3d32a4735024d01754d8eda21b45463ccaba730cbaf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41984&comment_hash=0cb0ea9ecd79236f5e59b3d32a4735024d01754d8eda21b45463ccaba730cbaf&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4970386972

   Thanks for your continued effort, @aikawa-ohno! However, there's a merge conflict atm. Can you help resolving?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4977870796

   **Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "aikawa-ohno (via GitHub)" <gi...@apache.org>.
aikawa-ohno commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4977108592

   @rusackas
   
   We apologize for any inconvenience caused by a few mishaps.
   Thank you for your feedback and for helping us address the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4953807446

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4954743612

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "aikawa-ohno (via GitHub)" <gi...@apache.org>.
aikawa-ohno commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4975040419

   @hainenber
   
   Thank you for contacting me.
   The conflict has been resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #41984:
URL: https://github.com/apache/superset/pull/41984#discussion_r3584516372


##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -16204,6 +15775,8 @@ msgid ""
 "You need access to the following tables: %(tables)s, "
 "'all_database_access' or 'all_datasource_access' permission"
 msgstr ""
+"テーブルへの以下のアクセス権が必要です:%(tables)s"
+"(「all_database_access」または「all_datasource_access)"

Review Comment:
   Good catch. Completed this one with balanced quotes and the missing 権限, so it renders the full permission message now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4953824669

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41984?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 56.13%. Comparing base ([`98c3ec7`](https://app.codecov.io/gh/apache/superset/commit/98c3ec7a7181acb179ce65ecdcc09174092a7685?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7a9e4c6`](https://app.codecov.io/gh/apache/superset/commit/7a9e4c6f626d13260b8de1a2ba2ecdb4571fb7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (98c3ec7) and HEAD (7a9e4c6). Click for more details.
   > 
   > <details><summary>HEAD has 54 uploads less than BASE</summary>
   >
   >| Flag | BASE (98c3ec7) | HEAD (7a9e4c6) |
   >|------|------|------|
   >|python|48|1|
   >|presto|8|1|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #41984      +/-   ##
   ==========================================
   - Coverage   65.04%   56.13%   -8.92%     
   ==========================================
     Files        2742     2742              
     Lines      153426   153426              
     Branches    35206    35206              
   ==========================================
   - Hits        99800    86120   -13680     
   - Misses      51722    66480   +14758     
   + Partials     1904      826    -1078     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.06% <ø> (ø)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.06% <ø> (-18.35%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/41984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41984?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(i18n): Update Japanese translations [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41984:
URL: https://github.com/apache/superset/pull/41984#issuecomment-4953835651

   <!-- Bito Reply -->
   The flagged issue is correct. Since the Japanese locale is configured with `nplurals=1`, providing `msgstr[1]` is invalid and can cause compilation errors or inconsistent behavior in gettext/Babel. To resolve this, you should remove the `msgstr[1]` entry for this pluralized string in the Japanese catalog. 
   
   I have checked the PR comments, and there are no other actionable suggestions in the provided `pr_comments.csv` file.
   
   **superset/translations/ja/LC_MESSAGES/messages.po**
   ```
   msgid "%(suggestion)s instead of \"%(undefinedParameter)s?\""
    msgid_plural ""
    "%(firstSuggestions)s or %(lastSuggestion)s instead of "
    "\"%(undefinedParameter)s\"?"
   -msgstr[0] "「%(undefinedParameter)s」の代わりに「%(suggestion)s」を使用しますか?"
   -+msgstr[1] "「%(undefinedParameter)s」の代わりに「%(firstSuggestions)s」または「%(lastSuggestion)s」を使用しますか?"
   +msgstr[0] "「%(undefinedParameter)s」の代わりに「%(suggestion)s」を使用しますか?"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org