You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/06/12 11:00:14 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/391
CLOUDSTACK-8555:Skip testcase for HyperV as it doesn't support volume resize operation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack test_browse_volume
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit 190171998a02facac513e4a1335b26bfd5338739
Author: pritisarap12 <pr...@clogeny.com>
Date: 2015-06-12T08:55:49Z
CLOUDSTACK-8555:Skip testcase for HyperV as it doesn't support volume resize operation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32393309
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2028,6 +2028,10 @@ def test_01_Browser_volume_Life_cycle_tpath(self):
"""
Test Browser_volume_Life_cycle - This includes upload volume,attach to a VM, write data ,Stop ,Start, Reboot,Reset of a VM, detach,attach back to the VM, delete volumes
"""
+ if self.hypervisor.lower() == 'hyperv':
--- End diff --
Can we skip only the resize volume test case with if condition and run test case for other operations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32394401
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2473,6 +2474,9 @@ def test_11_migrate_upload_volume(self):
"""
Test Browser_Upload_Volume_migrate_upload_volume
"""
+ if self.hypervisor.lower() == 'hyperv':
--- End diff --
Remove this old code snippet which skips the whole test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32393907
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2028,6 +2028,10 @@ def test_01_Browser_volume_Life_cycle_tpath(self):
"""
Test Browser_volume_Life_cycle - This includes upload volume,attach to a VM, write data ,Stop ,Start, Reboot,Reset of a VM, detach,attach back to the VM, delete volumes
"""
+ if self.hypervisor.lower() == 'hyperv':
--- End diff --
Yes, we can skip only resize operation and done with modification of the code doing the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/391#discussion_r32392227
--- Diff: test/integration/component/test_browse_volumes.py ---
@@ -2028,6 +2028,10 @@ def test_01_Browser_volume_Life_cycle_tpath(self):
"""
Test Browser_volume_Life_cycle - This includes upload volume,attach to a VM, write data ,Stop ,Start, Reboot,Reset of a VM, detach,attach back to the VM, delete volumes
"""
+ if self.hypervisor.lower() == 'hyperv':
+ self.skipTest("cann't be run for % hypervisor as it doesn't support volume resize operation" % self.hypervisor)
--- End diff --
Should be %s instead of %. Change for all applicable places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/391#issuecomment-111934294
Done with the review changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8555:Skip testcase for HyperV ...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/391#issuecomment-111963156
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---