You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/06/14 23:26:16 UTC
Review Request 74477: RANGER-4286: allow security-zone to exist without any services/resources assigned
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74477/
-----------------------------------------------------------
Review request for ranger, Abhishek Kumar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4286
https://issues.apache.org/jira/browse/RANGER-4286
Repository: ranger
Description
-------
updated validation of create/update of security-zone to allow security-zone to exist without any service/resources
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java cb4f37cc0
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java e079b7c46
agents-common/src/main/java/org/apache/ranger/plugin/store/SecurityZonePredicateUtil.java f2c381925
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 4653dc31a
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidatorTest.java dcc970c47
Diff: https://reviews.apache.org/r/74477/diff/1/
Testing
-------
- added/updated tests to cover security-zone create/update without any service/resource
- verified that all existing tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 74477: RANGER-4286: allow security-zone to exist without any services/resources assigned
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74477/
-----------------------------------------------------------
(Updated June 15, 2023, 1:39 a.m.)
Review request for ranger, Abhishek Kumar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Changes
-------
addressed the review comment.
Bugs: RANGER-4286
https://issues.apache.org/jira/browse/RANGER-4286
Repository: ranger
Description
-------
updated validation of create/update of security-zone to allow security-zone to exist without any service/resources
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java cb4f37cc0
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java e079b7c46
agents-common/src/main/java/org/apache/ranger/plugin/store/SecurityZonePredicateUtil.java f2c381925
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 4653dc31a
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidatorTest.java dcc970c47
Diff: https://reviews.apache.org/r/74477/diff/2/
Changes: https://reviews.apache.org/r/74477/diff/1-2/
Testing
-------
- added/updated tests to cover security-zone create/update without any service/resource
- verified that all existing tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 74477: RANGER-4286: allow security-zone to exist without any services/resources assigned
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74477/#review225545
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/store/SecurityZonePredicateUtil.java
Line 41 (original), 41 (patched)
<https://reviews.apache.org/r/74477/#comment314092>
Do we need predicate for MatchingZoneName? I think it will be useful.
- Abhay Kulkarni
On June 14, 2023, 11:26 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74477/
> -----------------------------------------------------------
>
> (Updated June 14, 2023, 11:26 p.m.)
>
>
> Review request for ranger, Abhishek Kumar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4286
> https://issues.apache.org/jira/browse/RANGER-4286
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated validation of create/update of security-zone to allow security-zone to exist without any service/resources
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java cb4f37cc0
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java e079b7c46
> agents-common/src/main/java/org/apache/ranger/plugin/store/SecurityZonePredicateUtil.java f2c381925
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 4653dc31a
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidatorTest.java dcc970c47
>
>
> Diff: https://reviews.apache.org/r/74477/diff/1/
>
>
> Testing
> -------
>
> - added/updated tests to cover security-zone create/update without any service/resource
> - verified that all existing tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74477: RANGER-4286: allow security-zone to exist without any services/resources assigned
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74477/#review225546
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On June 14, 2023, 11:26 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74477/
> -----------------------------------------------------------
>
> (Updated June 14, 2023, 11:26 p.m.)
>
>
> Review request for ranger, Abhishek Kumar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4286
> https://issues.apache.org/jira/browse/RANGER-4286
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated validation of create/update of security-zone to allow security-zone to exist without any service/resources
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java cb4f37cc0
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java e079b7c46
> agents-common/src/main/java/org/apache/ranger/plugin/store/SecurityZonePredicateUtil.java f2c381925
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 4653dc31a
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidatorTest.java dcc970c47
>
>
> Diff: https://reviews.apache.org/r/74477/diff/1/
>
>
> Testing
> -------
>
> - added/updated tests to cover security-zone create/update without any service/resource
> - verified that all existing tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>