You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2018/02/05 23:35:10 UTC

mesos git commit: Updated `reservation.md`.

Repository: mesos
Updated Branches:
  refs/heads/master 7ace6c4c2 -> d831e27b7


Updated `reservation.md`.

When using the Operator API, I came to this document to get a better
understand of resource reservations. It wasn't clear to me that
the reservation or reservations keys were a requirement given that
the principal configuration is optional. What I do know is that
the role can be set in the resource object or the reservation object.
I think we might as well instruct users to set the role in
the reservation object so it is more clear that it is required to
successfully POST the request. After a quick google search, I noted
that another user ran into the same issue and posted about it in IRC.

This closes #262


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d831e27b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d831e27b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d831e27b

Branch: refs/heads/master
Commit: d831e27b73a72ed682fd31ea7c053e0861e82029
Parents: 7ace6c4
Author: Demitri Swan <ds...@digitalocean.com>
Authored: Mon Feb 5 15:25:09 2018 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Mon Feb 5 15:25:09 2018 -0800

----------------------------------------------------------------------
 docs/reservation.md | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/d831e27b/docs/reservation.md
----------------------------------------------------------------------
diff --git a/docs/reservation.md b/docs/reservation.md
index 269c652..33f58c3 100644
--- a/docs/reservation.md
+++ b/docs/reservation.md
@@ -623,18 +623,18 @@ We send an HTTP POST request to the master's
               "name": "cpus",
               "type": "SCALAR",
               "scalar": { "value": 8 },
-              "role": "ads",
               "reservation": {
-                "principal": <operator_principal>
+                "principal": <operator_principal>,
+                "role": "ads"
               }
             },
             {
               "name": "mem",
               "type": "SCALAR",
               "scalar": { "value": 4096 },
-              "role": "ads",
               "reservation": {
-                "principal": <operator_principal>
+                "principal": <operator_principal>,
+                "role": "ads"
               }
             }
           ]' \
@@ -671,18 +671,18 @@ We can send an HTTP POST request to the master's
               "name": "cpus",
               "type": "SCALAR",
               "scalar": { "value": 8 },
-              "role": "ads",
               "reservation": {
-                "principal": <reserver_principal>
+                "principal": <reserver_principal>,
+                "role": "ads"
               }
             },
             {
               "name": "mem",
               "type": "SCALAR",
               "scalar": { "value": 4096 },
-              "role": "ads",
               "reservation": {
-                "principal": <reserver_principal>
+                "principal": <reserver_principal>,
+                "role": "ads"
               }
             }
           ]' \