You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/24 00:15:38 UTC

[GitHub] [spark] viirya commented on a change in pull request #29526: [SPARK-32352][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Exclude partition columns from data columns

viirya commented on a change in pull request #29526:
URL: https://github.com/apache/spark/pull/29526#discussion_r475286626



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
##########
@@ -176,9 +176,10 @@ object FileSourceStrategy extends Strategy with PredicateHelper with Logging {
         l.resolve(fsRelation.dataSchema, fsRelation.sparkSession.sessionState.analyzer.resolver)
 
       // Partition keys are not available in the statistics of the files.
+      val dataColumnsWithoutPartitionCols = dataColumns.filterNot(partitionColumns.contains)

Review comment:
       Sure. Added.
   
   It only happens in hive-1.2 profile, because for hive-2.3 we go for a different path to create pushed down filters. In that path, we have checked if an attribute is in the field map.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org