You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/16 16:47:00 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #10069: Update prefer_typescript.yml

etr2460 opened a new pull request #10069:
URL: https://github.com/apache/incubator-superset/pull/10069


   ### SUMMARY
   This fixes some uncommon issues with this workflow. According to https://github.com/trilom/file-changes-action/issues/100#issuecomment-639417833, the master release should always be safe.
   
   
   ### TEST PLAN
   CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @nytai @ktmud 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud edited a comment on pull request #10069: build: update prefer_typescript.yml

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10069:
URL: https://github.com/apache/incubator-superset/pull/10069#issuecomment-644910233


   Sorry for chiming in late, but I think having a fixed version is also more about stability rather than speed. We don't want things suddenly break just because the dependent repo changed its API.
   
   In the future, if we know a fix is in, we can simply use the latest good git SHA if it hasn't release to a new version yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10069: build: update prefer_typescript.yml

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10069:
URL: https://github.com/apache/incubator-superset/pull/10069#issuecomment-644890711


   good to know, thanks for the heads up! it still runs pretty fast like you said, but it's helpful to understand the implications


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 merged pull request #10069: build: update prefer_typescript.yml

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10069:
URL: https://github.com/apache/incubator-superset/pull/10069


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #10069: build: update prefer_typescript.yml

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10069:
URL: https://github.com/apache/incubator-superset/pull/10069#issuecomment-644910233


   Sorry for chiming in late, but I think having a fixed version is also more about stability rather than speed. We don't want things suddenly break just because the dependent repo changed its API.
   
   In the future, if we know a fix is in, we can simply use the latest good git SHA if it hasn't been release to a new version yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org