You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by fm...@apache.org on 2008/10/24 08:29:16 UTC
svn commit: r707558 - in /felix/trunk/webconsole/src/main:
java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
resources/res/ui/datatable.js
Author: fmeschbe
Date: Thu Oct 23 23:29:15 2008
New Revision: 707558
URL: http://svn.apache.org/viewvc?rev=707558&view=rev
Log:
Fix a display issue where data should be displayed in red but instead html code
linke <span style="red">..</style> is displayed. Now lines are displayed in
red, if they are prefixed with double exclamation marks (!!)
Modified:
felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
felix/trunk/webconsole/src/main/resources/res/ui/datatable.js
Modified: felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java?rev=707558&r1=707557&r2=707558&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java (original)
+++ felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java Thu Oct 23 23:29:15 2008
@@ -872,7 +872,7 @@
boolean bootDel = isBootDelegated( name );
if ( bootDel )
{
- val.append( "<span style=\"color: red\">!! " );
+ val.append( "!! " );
}
val.append( name );
@@ -881,7 +881,7 @@
if ( bootDel )
{
- val.append( " -- Overwritten by Boot Delegation</span>" );
+ val.append( " -- Overwritten by Boot Delegation" );
}
val.append( "<br />" );
@@ -895,7 +895,7 @@
if ( isSpan )
{
- val.append( "<span style=\"color: red\">!! " );
+ val.append( "!! " );
}
val.append( name );
@@ -926,11 +926,6 @@
}
}
- if ( isSpan )
- {
- val.append( "</span>" );
- }
-
val.append( "<br />" );
}
Modified: felix/trunk/webconsole/src/main/resources/res/ui/datatable.js
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/resources/res/ui/datatable.js?rev=707558&r1=707557&r2=707558&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/resources/res/ui/datatable.js (original)
+++ felix/trunk/webconsole/src/main/resources/res/ui/datatable.js Thu Oct 23 23:29:15 2008
@@ -187,13 +187,22 @@
var proptd = td( "aligntop" );
trEl.appendChild( proptd );
- if (prop.value )
+ if (prop.value)
{
var values = new String( prop.value ).split( "<br />" );
for (var i=0; i < values.length; i++)
{
if (i > 0) { proptd.appendChild( createElement( "br" ) ); }
- addText( proptd, values[i] );
+
+ var span;
+ if (values[i].substring(0, 2) == "!!") {
+ span = createElement( "span", null, { style: { color: "red" } } );
+ proptd.appendChild( span );
+ } else {
+ span = proptd;
+ }
+
+ addText( span, values[i] );
}
}
else