You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/02 00:49:44 UTC
[GitHub] [spark] maropu opened a new pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
maropu opened a new pull request #29928:
URL: https://github.com/apache/spark/pull/29928
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
(This is a followup PR of #29585) The PR modified `RuleExecutor#isPlanIntegral` code for checking if a plan has globally-unique attribute IDs, but this check made Jenkins test jobs much longer (See [the Dongjoon comment](https://github.com/apache/spark/pull/29585#issuecomment-702461314) and thanks, @dongjoon-hyun !). To recover running time for Jenkins tests, this PR intends to update the code to run plan integrity check only for effective plans.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To recover running time for Jenkins tests.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702493074
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33942/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702481858
**[Test build #129329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129329/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702605549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702570726
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702484173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702605562
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33952/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702557984
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702485304
**[Test build #129331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129331/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702697517
**[Test build #129341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129341/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702474382
**[Test build #129327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129327/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702550362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702580265
**[Test build #129341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129341/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702830961
Thank you so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702481207
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702575395
**[Test build #129340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129340/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702481030
@maropu . Could you run `Maven` run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702575395
**[Test build #129340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129340/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702469988
I will check the running time of Jenkins. cc: @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702789986
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702557984
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702550362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702497506
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33942/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702564672
> This PR is still an improvement follow-up. Did I understand correctly, @maropu ?
Yea, right, I think so. The latest test run seems much faster than the previous ones: `Took 5 hr 6 min` v.s. `6 hr 41-45 min` https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129329/
I'm not 100% sure that this is true now, but probably, that's because this update skips the other unencessary integrity checks, too:
https://github.com/apache/spark/blob/f7ba95264d38484f57c772e459bffb939c9c718e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702497525
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33942/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702594069
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29928:
URL: https://github.com/apache/spark/pull/29928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702605535
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702485304
**[Test build #129331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129331/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702571075
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129331/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702474382
**[Test build #129327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129327/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702481858
**[Test build #129329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129329/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702558278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129329/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702577325
(I will re-run the test a couple of times before merging this..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702571075
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129331/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702497520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702549053
**[Test build #129329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129329/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702484151
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33940/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702789995
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129340/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702830961
Thank you so much again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702580265
**[Test build #129341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129341/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702788111
**[Test build #129340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129340/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702554167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702481030
@maropu . Could you run `Maven` run? SBT run is parallelized by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702482043
Thanks for the update, @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702698508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702605549
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702484173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702789986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702555664
Oh, is it recovered? It's great, @maropu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702558278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129329/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702480328
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33940/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702698508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702497520
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun removed a comment on pull request #29928: [SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702557911
This PR is still an improvement follow-up. Did I understand correctly, @maropu ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702565017
**[Test build #129331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129331/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702727479
I checked `Took 5 hr 36 min` in https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129341/testReport/
This PR looks fine, so I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702480901
Thank you for this investigation, @maropu .
Also, cc @cloud-fan .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702577808
Sure, go ahead~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29928: [WIP][SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plans
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702544470
**[Test build #129327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129327/testReport)** for PR 29928 at commit [`6582f90`](https://github.com/apache/spark/commit/6582f9014338adab33b121c724d270233ce2f642).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702728222
Thanks, @dongjoon-hyun ! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702570726
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP][test-maven] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702557911
This PR is still an improvement follow-up. Did I understand correctly, @maropu ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29928: [SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29928:
URL: https://github.com/apache/spark/pull/29928#issuecomment-702558357
Thank you so much, @maropu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org