[GitHub] [maven-plugin-tools] gaul commented on a change in pull request #17: Do not throw exception in finally block

[GitBox <gi...@apache.org>]

gaul commented on a change in pull request #17: Do not throw exception in finally block
URL: https://github.com/apache/maven-plugin-tools/pull/17#discussion_r319730624
 
 

 ##########
 File path: maven-plugin-tools-generators/src/main/resources/help-class-source.vm
 ##########
 @@ -144,7 +144,7 @@ public class HelpMojo
                 }
                 catch ( IOException e )
                 {
-                    throw new MojoExecutionException( e.getMessage(), e );
+                    getLog().warn( "Could not close " + PLUGIN_HELP_PATH + ": " + e.getMessage() );
 
 Review comment:
   I would like to let maven plugins use error-prone with the fewest suppressions.  Moving the entire project to Java 7 is one way to do this although I don't know if that aligns with the project's goals.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services