[GitHub] [superset] betodealmeida commented on pull request #17265: fix: Allow users to update database in Dataset Edit Modal

[GitBox <gi...@apache.org>]

betodealmeida commented on pull request #17265:
URL: https://github.com/apache/superset/pull/17265#issuecomment-955054310


   @hughhhh I tested and it works. Let's merge this to unblock Max, but we need to add unit tests and make it more resilient.
   
   Right now if you change the DB the user can still save the dataset even if the schema and table name are empty, which is bad.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org