You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/08/22 23:47:43 UTC
[GitHub] trafficserver pull request #897: TS-4772: Add delay and max-age control to t...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/897
TS-4772: Add delay and max-age control to the generator plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4772
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/897.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #897
----
commit 733fc38d7cadde67c05770647b5bde66252fb0ca
Author: James Peach <jp...@apache.org>
Date: 2016-08-22T20:06:51Z
TS-4772: Add delay and max-age control to the generator plugin.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/897
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/481/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/897
It is done in headers so that you can trivially hit the same URL with different attributes. For example, hit URL1 with a short MaxAge to populate the cache. Then hit URL1 again with a long delay to lock the cache entry, then hit URL1. This is much harder to do with query parameters, though I have no objection to adding them as an additional mechanism.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/897
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/480/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/897
I dislike the inconsistency, but your explanation / use case makes a lot of sense. And if we agree that this makes things better, and not worse, do it. Maybe file a Jira to have a future addition to support both headers and URIs for all parameters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #897: TS-4772: Add delay and max-age control to t...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/897
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/897
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/586/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/897
Instead of headers I would like to seem them in the URL. Possibly as query parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/897
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/584/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/897
Are we good with headers (at least for now)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #897: TS-4772: Add delay and max-age control to the gene...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/897
I guess I don't have a strong opinion, but it seems unfortunate to me to introduce these new options as headers, rather than URI components. The original plugin for lighthttpd did everything in the URI paths, no? Keeping it this way seems more consistent, and easier to use for e.g. setting up various performance and load patters where you want to mix various options for various requests.
In a sense, it'd cool to mimic some of the behavior of httpbin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---