[jira] Commented: (MYFACES-1494) FacesServlet.service() have _lifecycle.execute(facesContext) and _lifecycle.render(facesContext) in the same try & catch block which is not relevant

["Martin Marinschek (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-1494?page=comments#action_12450320 ] 
            
Martin Marinschek commented on MYFACES-1494:
--------------------------------------------

Why would I want to render anything if there is an exception in the execute step?

Wouldn't it be better to forward to something else entirely (=an error page) if an error occurred?

regards,

Martin

> FacesServlet.service() have 	_lifecycle.execute(facesContext) and _lifecycle.render(facesContext) in the same try & catch block which is not relevant
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1494
>                 URL: http://issues.apache.org/jira/browse/MYFACES-1494
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.1.4
>         Environment: All plateform
>            Reporter: David Lapetina
>            Priority: Trivial
>
> In the service() method of FacesServlet you have the following code :
>         try {
> 			_lifecycle.execute(facesContext);
> 			_lifecycle.render(facesContext);
> 	} catch (Throwable e)  {
>              ...
> So, if an exception occurs in the execute step it is impossible to do the render step and the consequence is a blank page which is not very user-friendly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira