[GitHub] [ozone] smengcl commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #4042:
URL: https://github.com/apache/ozone/pull/4042#discussion_r1065016580


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java:
##########
@@ -322,4 +323,11 @@ public Table<String, OmKeyInfo> getKeyTable() {
         getOmMetadataManager().getKeyTable(getBucketLayout());
     return keyTable;
   }
+
+  @Override
+  public OmDirectoryInfo getDirInfo(String[] names) throws IOException {
+    return OmDirectoryInfo.newBuilder()
+        .setName(names[2])

Review Comment:
   @devmadhuu I get that the only caller (at the moment) calling this method won't cause issues. I'm fine with either adding or not adding the check but I would prefer the former.
   
   Same goes for the method in `FSOBucketHandler`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org