You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/08/02 07:38:40 UTC
[GitHub] [hbase] abhradeepkundu opened a new pull request, #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
abhradeepkundu opened a new pull request, #4673:
URL: https://github.com/apache/hbase/pull/4673
This is the tool to read the content of StoreFileTrackerFile in plain english.
The tool can be run by giving direct path to the storefiletrackerfile, by specifying -f option
OR
by providing information like region name(-r option), table name (-t option) and column family (-cf option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1202563499
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 21s | master passed |
| +1 :green_heart: | compile | 1m 26s | master passed |
| +1 :green_heart: | shadedjars | 3m 56s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 40s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 9s | the patch passed |
| +1 :green_heart: | compile | 1m 27s | the patch passed |
| +1 :green_heart: | javac | 1m 27s | the patch passed |
| -1 :x: | shadedjars | 3m 1s | patch has 10 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 1m 18s | root generated 4 new + 80 unchanged - 4 fixed = 84 total (was 84) |
||| _ Other Tests _ |
| -1 :x: | unit | 322m 14s | root in the patch failed. |
| | | 343m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux bc15bfe80fb7 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e8c14ee308 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt |
| unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/testReport/ |
| Max. process+thread count | 2380 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] abhradeepkundu commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
abhradeepkundu commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r938002394
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLine;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLineParser;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.HelpFormatter;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Option;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.OptionGroup;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.ParseException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.PosixParser;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true,
+ "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true,
+ "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
Review Comment:
Done, I have put "/root/hbase-3.0.0-alpha-4-SNAPSHOT/hbase-data/data/default/tbl-sft/093fa06bf84b3b631007f951a14b8457/f/.filelist/f2.1655139542249" this one only as an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] abhradeepkundu commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
abhradeepkundu commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r936499582
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,192 @@
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.*;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionFileSystem;
+import org.apache.hadoop.hbase.regionserver.StoreContext;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.*;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.zip.CRC32;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true, "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true, "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
+ options.addOptionGroup(files);
+ }
+
+ public boolean parseOptions(String args[]) throws ParseException, IOException {
+ HelpFormatter formatter = new HelpFormatter();
+ if (args.length == 0) {
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ return false;
+ }
+
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmd = parser.parse(options, args);
+
+ if (cmd.hasOption(fileOption)) {
+ path = new Path(cmd.getOptionValue(fileOption));
+ } else {
+ regionName = cmd.getOptionValue(regionOption);
+ if(StringUtils.isEmpty(regionName)) {
+ err.println("Region name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ columnFamily = cmd.getOptionValue(columnFamilyOption);
+ if(StringUtils.isEmpty(columnFamily)) {
+ err.println("Column family is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ String tableNameWtihNS = cmd.getOptionValue(tableNameOption);
+ if(StringUtils.isEmpty(tableNameWtihNS)) {
+ err.println("Table name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ TableName tn = TableName.valueOf(tableNameWtihNS);
+ namespace = tn.getNamespaceAsString();
+ tableName = tn.getNameAsString();
+ }
+ return true;
+ }
+
+ public int run(String[] args) {
+ if(getConf() == null) {
+ throw new RuntimeException("A Configuration instance must be provided.");
+ }
+ try {
+ CommonFSUtils.setFsDefault(getConf(), CommonFSUtils.getRootDir(getConf()));
+ if (!parseOptions(args)) {
+ return 1;
+ }
+ } catch (IOException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ } catch (ParseException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ }
+ FileSystem fs = null;
+ if(path != null) {
+ try {
+ fs = path.getFileSystem(getConf());
+ if(fs.isDirectory(path)) {
+ err.println("ERROR, wrong path given: " + path);
+ return -2;
Review Comment:
done
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,192 @@
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.*;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionFileSystem;
+import org.apache.hadoop.hbase.regionserver.StoreContext;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.*;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.zip.CRC32;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true, "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true, "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
+ options.addOptionGroup(files);
+ }
+
+ public boolean parseOptions(String args[]) throws ParseException, IOException {
+ HelpFormatter formatter = new HelpFormatter();
+ if (args.length == 0) {
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ return false;
+ }
+
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmd = parser.parse(options, args);
+
+ if (cmd.hasOption(fileOption)) {
+ path = new Path(cmd.getOptionValue(fileOption));
+ } else {
+ regionName = cmd.getOptionValue(regionOption);
+ if(StringUtils.isEmpty(regionName)) {
+ err.println("Region name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ columnFamily = cmd.getOptionValue(columnFamilyOption);
+ if(StringUtils.isEmpty(columnFamily)) {
+ err.println("Column family is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ String tableNameWtihNS = cmd.getOptionValue(tableNameOption);
+ if(StringUtils.isEmpty(tableNameWtihNS)) {
+ err.println("Table name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ TableName tn = TableName.valueOf(tableNameWtihNS);
+ namespace = tn.getNamespaceAsString();
+ tableName = tn.getNameAsString();
+ }
+ return true;
+ }
+
+ public int run(String[] args) {
+ if(getConf() == null) {
+ throw new RuntimeException("A Configuration instance must be provided.");
+ }
+ try {
+ CommonFSUtils.setFsDefault(getConf(), CommonFSUtils.getRootDir(getConf()));
+ if (!parseOptions(args)) {
+ return 1;
+ }
+ } catch (IOException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ } catch (ParseException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ }
+ FileSystem fs = null;
+ if(path != null) {
+ try {
+ fs = path.getFileSystem(getConf());
+ if(fs.isDirectory(path)) {
+ err.println("ERROR, wrong path given: " + path);
+ return -2;
+ }
+ return print(fs, path);
+ } catch (IOException e) {
+ LOG.error("Error reading " + path, e);
+ return -2;
+ }
+ } else {
+ try {
+ Path root = CommonFSUtils.getRootDir(getConf());
+ Path baseDir = new Path(root, HConstants.BASE_NAMESPACE_DIR);
+ Path nameSpacePath = new Path(baseDir, namespace);
+ Path tablePath = new Path(nameSpacePath, tableName);
+ Path regionPath = new Path(tablePath, regionName);
+ Path cfPath = new Path(regionPath, columnFamily);
+ Path sftPath = new Path(cfPath, StoreFileListFile.TRACK_FILE_DIR);
+
+ fs = FileSystem.newInstance(regionPath.toUri(), getConf());
+
+ RemoteIterator<LocatedFileStatus> iterator = fs.listFiles(sftPath, false);
+
+ while (iterator.hasNext()) {
+ LocatedFileStatus lfs = iterator.next();
+ if(lfs.isFile() && StoreFileListFile.TRACK_FILE_PATTERN.matcher(lfs.getPath().getName()).matches()) {
+ out.println("Printing contents for file " + lfs.getPath().toString());
+ int ret = print(fs, lfs.getPath());
+ if(ret < 0) {
+ return ret;
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1204077855
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 39s | master passed |
| +1 :green_heart: | compile | 1m 41s | master passed |
| +1 :green_heart: | shadedjars | 3m 51s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 8s | master passed |
| -0 :warning: | patch | 6m 11s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 24s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 250m 7s | root in the patch passed. |
| | | 274m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f7b308898a3d 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/testReport/ |
| Max. process+thread count | 4921 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1205765619
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 43s | master passed |
| +1 :green_heart: | compile | 1m 48s | master passed |
| +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 7s | master passed |
| -0 :warning: | patch | 6m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 28s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 7s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 253m 20s | root in the patch passed. |
| | | 278m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 804cb817c8fb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 2ac5578730 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/testReport/ |
| Max. process+thread count | 4717 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] abhradeepkundu commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
abhradeepkundu commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r936499862
##########
bin/hbase:
##########
@@ -83,6 +83,7 @@ show_usage() {
if [ "${in_omnibus_tarball}" = "true" ]; then
echo " wal Write-ahead-log analyzer"
echo " hfile Store file analyzer"
+ echo " sft Store file tracker viewer"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1202418017
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 42s | master passed |
| +1 :green_heart: | compile | 1m 44s | master passed |
| +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 14s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 27s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| -1 :x: | shadedjars | 3m 7s | patch has 10 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 56s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 251m 40s | root in the patch passed. |
| | | 278m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 10b656d0f39f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e8c14ee308 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/testReport/ |
| Max. process+thread count | 4845 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1205551248
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 15s | master passed |
| +1 :green_heart: | compile | 6m 16s | master passed |
| +1 :green_heart: | checkstyle | 1m 1s | master passed |
| +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 8m 50s | master passed |
| -0 :warning: | patch | 7m 46s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 16s | the patch passed |
| +1 :green_heart: | compile | 6m 14s | the patch passed |
| +1 :green_heart: | javac | 6m 14s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 0s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 20s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 8m 58s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 56m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a80a16749e8f 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 2ac5578730 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 140 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203173992
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 13s | master passed |
| +1 :green_heart: | compile | 1m 26s | master passed |
| +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | master passed |
| -0 :warning: | patch | 5m 44s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 13s | the patch passed |
| +1 :green_heart: | compile | 1m 27s | the patch passed |
| +1 :green_heart: | javac | 1m 27s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 56s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 38s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 386m 5s | root in the patch passed. |
| | | 408m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a35f3bf8873c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/testReport/ |
| Max. process+thread count | 4853 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r935341877
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,192 @@
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.*;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionFileSystem;
+import org.apache.hadoop.hbase.regionserver.StoreContext;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.*;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.zip.CRC32;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true, "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true, "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
+ options.addOptionGroup(files);
+ }
+
+ public boolean parseOptions(String args[]) throws ParseException, IOException {
+ HelpFormatter formatter = new HelpFormatter();
+ if (args.length == 0) {
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ return false;
+ }
+
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmd = parser.parse(options, args);
+
+ if (cmd.hasOption(fileOption)) {
+ path = new Path(cmd.getOptionValue(fileOption));
+ } else {
+ regionName = cmd.getOptionValue(regionOption);
+ if(StringUtils.isEmpty(regionName)) {
+ err.println("Region name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ columnFamily = cmd.getOptionValue(columnFamilyOption);
+ if(StringUtils.isEmpty(columnFamily)) {
+ err.println("Column family is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ String tableNameWtihNS = cmd.getOptionValue(tableNameOption);
+ if(StringUtils.isEmpty(tableNameWtihNS)) {
+ err.println("Table name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ TableName tn = TableName.valueOf(tableNameWtihNS);
+ namespace = tn.getNamespaceAsString();
+ tableName = tn.getNameAsString();
+ }
+ return true;
+ }
+
+ public int run(String[] args) {
+ if(getConf() == null) {
+ throw new RuntimeException("A Configuration instance must be provided.");
+ }
+ try {
+ CommonFSUtils.setFsDefault(getConf(), CommonFSUtils.getRootDir(getConf()));
+ if (!parseOptions(args)) {
+ return 1;
+ }
+ } catch (IOException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ } catch (ParseException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ }
+ FileSystem fs = null;
+ if(path != null) {
+ try {
+ fs = path.getFileSystem(getConf());
+ if(fs.isDirectory(path)) {
+ err.println("ERROR, wrong path given: " + path);
+ return -2;
+ }
+ return print(fs, path);
+ } catch (IOException e) {
+ LOG.error("Error reading " + path, e);
+ return -2;
+ }
+ } else {
+ try {
+ Path root = CommonFSUtils.getRootDir(getConf());
+ Path baseDir = new Path(root, HConstants.BASE_NAMESPACE_DIR);
+ Path nameSpacePath = new Path(baseDir, namespace);
+ Path tablePath = new Path(nameSpacePath, tableName);
+ Path regionPath = new Path(tablePath, regionName);
+ Path cfPath = new Path(regionPath, columnFamily);
+ Path sftPath = new Path(cfPath, StoreFileListFile.TRACK_FILE_DIR);
+
+ fs = FileSystem.newInstance(regionPath.toUri(), getConf());
+
+ RemoteIterator<LocatedFileStatus> iterator = fs.listFiles(sftPath, false);
+
+ while (iterator.hasNext()) {
+ LocatedFileStatus lfs = iterator.next();
+ if(lfs.isFile() && StoreFileListFile.TRACK_FILE_PATTERN.matcher(lfs.getPath().getName()).matches()) {
+ out.println("Printing contents for file " + lfs.getPath().toString());
+ int ret = print(fs, lfs.getPath());
+ if(ret < 0) {
+ return ret;
+ }
Review Comment:
nit: maybe worth still try to print the remaining files before returning error code?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,192 @@
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.*;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionFileSystem;
+import org.apache.hadoop.hbase.regionserver.StoreContext;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.*;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.zip.CRC32;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true, "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true, "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
+ options.addOptionGroup(files);
+ }
+
+ public boolean parseOptions(String args[]) throws ParseException, IOException {
+ HelpFormatter formatter = new HelpFormatter();
+ if (args.length == 0) {
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ return false;
+ }
+
+ CommandLineParser parser = new PosixParser();
+ CommandLine cmd = parser.parse(options, args);
+
+ if (cmd.hasOption(fileOption)) {
+ path = new Path(cmd.getOptionValue(fileOption));
+ } else {
+ regionName = cmd.getOptionValue(regionOption);
+ if(StringUtils.isEmpty(regionName)) {
+ err.println("Region name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ columnFamily = cmd.getOptionValue(columnFamilyOption);
+ if(StringUtils.isEmpty(columnFamily)) {
+ err.println("Column family is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ String tableNameWtihNS = cmd.getOptionValue(tableNameOption);
+ if(StringUtils.isEmpty(tableNameWtihNS)) {
+ err.println("Table name is not specified.");
+ formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+ System.exit(-1);
+ }
+ TableName tn = TableName.valueOf(tableNameWtihNS);
+ namespace = tn.getNamespaceAsString();
+ tableName = tn.getNameAsString();
+ }
+ return true;
+ }
+
+ public int run(String[] args) {
+ if(getConf() == null) {
+ throw new RuntimeException("A Configuration instance must be provided.");
+ }
+ try {
+ CommonFSUtils.setFsDefault(getConf(), CommonFSUtils.getRootDir(getConf()));
+ if (!parseOptions(args)) {
+ return 1;
+ }
+ } catch (IOException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ } catch (ParseException ex) {
+ LOG.error("Error parsing command-line options", ex);
+ return 1;
+ }
+ FileSystem fs = null;
+ if(path != null) {
+ try {
+ fs = path.getFileSystem(getConf());
+ if(fs.isDirectory(path)) {
+ err.println("ERROR, wrong path given: " + path);
+ return -2;
Review Comment:
nit: follow posix standards for return errors (>0)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1202693543
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 14s | master passed |
| +1 :green_heart: | compile | 6m 17s | master passed |
| +1 :green_heart: | checkstyle | 1m 2s | master passed |
| +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 8m 43s | master passed |
| -0 :warning: | patch | 7m 40s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 13s | the patch passed |
| +1 :green_heart: | compile | 6m 19s | the patch passed |
| -0 :warning: | javac | 6m 19s | root generated 1 new + 1066 unchanged - 1 fixed = 1067 total (was 1067) |
| -0 :warning: | checkstyle | 1m 0s | root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 29s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 9m 8s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 57m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fc5dca459956 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| Max. process+thread count | 139 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil merged pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
wchevreuil merged PR #4673:
URL: https://github.com/apache/hbase/pull/4673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203432506
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 9s | master passed |
| +1 :green_heart: | compile | 1m 24s | master passed |
| +1 :green_heart: | shadedjars | 3m 55s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | master passed |
| -0 :warning: | patch | 5m 45s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 6s | the patch passed |
| +1 :green_heart: | compile | 1m 26s | the patch passed |
| +1 :green_heart: | javac | 1m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 387m 13s | root in the patch passed. |
| | | 408m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 21e27f2a781a 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/testReport/ |
| Max. process+thread count | 4805 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1202200582
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 23s | master passed |
| +1 :green_heart: | compile | 6m 20s | master passed |
| +1 :green_heart: | checkstyle | 1m 1s | master passed |
| +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 8m 52s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 13s | the patch passed |
| +1 :green_heart: | compile | 6m 12s | the patch passed |
| +1 :green_heart: | javac | 6m 12s | the patch passed |
| -0 :warning: | checkstyle | 1m 1s | root: The patch generated 31 new + 0 unchanged - 0 fixed = 31 total (was 0) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| -1 :x: | spotless | 0m 37s | patch has 65 errors when running spotless:check, run spotless:apply to fix. |
| +1 :green_heart: | spotbugs | 9m 15s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | asflicense | 0m 21s | The patch generated 2 ASF License warnings. |
| | | 62m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux eae68d04a40d 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e8c14ee308 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-general-check/output/patch-spotless.txt |
| asflicense | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 138 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/1/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r936823951
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLine;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLineParser;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.HelpFormatter;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Option;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.OptionGroup;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.ParseException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.PosixParser;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true,
+ "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true,
+ "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
Review Comment:
Nit: Better not to use meta table path as an example.
Nit: it doesn't need a full url, i.e., when testing this on pseudo distributed on local FS, I could get it working with just: `/root/hbase-3.0.0-alpha-4-SNAPSHOT/hbase-data/data/default/tbl-sft/093fa06bf84b3b631007f951a14b8457/f/.filelist/f2.1655139542249`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1204257056
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 9s | master passed |
| +1 :green_heart: | compile | 1m 25s | master passed |
| +1 :green_heart: | shadedjars | 3m 57s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | master passed |
| -0 :warning: | patch | 5m 47s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 10s | the patch passed |
| +1 :green_heart: | compile | 1m 26s | the patch passed |
| +1 :green_heart: | javac | 1m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 55s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 385m 32s | root in the patch passed. |
| | | 406m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 42a59ffb17e7 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/testReport/ |
| Max. process+thread count | 4758 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203236529
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 25s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 36s | master passed |
| +1 :green_heart: | compile | 8m 41s | master passed |
| +1 :green_heart: | checkstyle | 1m 6s | master passed |
| +1 :green_heart: | spotless | 0m 49s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 12m 12s | master passed |
| -0 :warning: | patch | 1m 49s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | the patch passed |
| +1 :green_heart: | compile | 8m 33s | the patch passed |
| -0 :warning: | javac | 8m 33s | root generated 1 new + 1066 unchanged - 1 fixed = 1067 total (was 1067) |
| +1 :green_heart: | checkstyle | 1m 11s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 14m 27s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| +1 :green_heart: | spotless | 0m 53s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 10m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| | | 73m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4bb3575c1193 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt |
| Max. process+thread count | 138 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] abhradeepkundu commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
abhradeepkundu commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r938002394
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLine;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLineParser;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.HelpFormatter;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Option;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.OptionGroup;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.ParseException;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.PosixParser;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.StoreFileTrackerProtos.StoreFileList;
+
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+@InterfaceStability.Evolving
+public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
+ private static final Logger LOG = LoggerFactory.getLogger(StoreFileListFilePrettyPrinter.class);
+
+ private Options options = new Options();
+
+ private final String fileOption = "f";
+ private final String columnFamilyOption = "cf";
+ private final String regionOption = "r";
+ private final String tableNameOption = "t";
+
+ private String namespace;
+ private String regionName;
+ private String columnFamily;
+ private String tableName;
+ private Path path;
+ private PrintStream err = System.err;
+ private PrintStream out = System.out;
+
+ public StoreFileListFilePrettyPrinter() {
+ super();
+ init();
+ }
+
+ public StoreFileListFilePrettyPrinter(Configuration conf) {
+ super(conf);
+ init();
+ }
+
+ private void init() {
+ OptionGroup files = new OptionGroup();
+ options.addOption(new Option(tableNameOption, "table", true,
+ "Table to scan. Pass table name; e.g. test_table"));
+ options.addOption(new Option(columnFamilyOption, "columnfamily", true,
+ "column family to scan. Pass column family name; e.g. f"));
+ files.addOption(new Option(regionOption, "region", true,
+ "Region to scan. Pass region name; e.g. '3d58e9067bf23e378e68c071f3dd39eb'"));
+ files.addOption(new Option(fileOption, "file", true,
+ "File to scan. Pass full-path; e.g. hdfs://a:9000/hbase/hbase:meta/12/34"));
Review Comment:
Done, I kept "/root/hbase-3.0.0-alpha-4-SNAPSHOT/hbase-data/data/default/tbl-sft/093fa06bf84b3b631007f951a14b8457/f/.filelist/f2.1655139542249" this one only as an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203056798
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 41s | master passed |
| +1 :green_heart: | compile | 1m 43s | master passed |
| +1 :green_heart: | shadedjars | 3m 51s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 8s | master passed |
| -0 :warning: | patch | 6m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 26s | the patch passed |
| +1 :green_heart: | compile | 1m 44s | the patch passed |
| +1 :green_heart: | javac | 1m 44s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 254m 16s | root in the patch passed. |
| | | 278m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 5a7a49b739be 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/testReport/ |
| Max. process+thread count | 4876 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203365580
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 47s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 33s | master passed |
| +1 :green_heart: | compile | 1m 45s | master passed |
| +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 6s | master passed |
| -0 :warning: | patch | 6m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 24s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 255m 10s | root in the patch passed. |
| | | 279m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a5a32e1558c3 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/testReport/ |
| Max. process+thread count | 4748 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1203842391
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 27s | master passed |
| +1 :green_heart: | compile | 7m 49s | master passed |
| +1 :green_heart: | checkstyle | 1m 6s | master passed |
| +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 10m 50s | master passed |
| -0 :warning: | patch | 9m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 37s | the patch passed |
| +1 :green_heart: | compile | 7m 59s | the patch passed |
| -0 :warning: | javac | 7m 59s | root generated 1 new + 1066 unchanged - 1 fixed = 1067 total (was 1067) |
| +1 :green_heart: | checkstyle | 1m 9s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 58s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| +1 :green_heart: | spotless | 0m 45s | patch has no errors when running spotless:check. |
| +1 :green_heart: | spotbugs | 12m 46s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| | | 69m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6874963028c2 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d734acc00e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt |
| Max. process+thread count | 139 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/4/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache9 commented on code in PR #4673:
URL: https://github.com/apache/hbase/pull/4673#discussion_r935355005
##########
bin/hbase:
##########
@@ -83,6 +83,7 @@ show_usage() {
if [ "${in_omnibus_tarball}" = "true" ]; then
echo " wal Write-ahead-log analyzer"
echo " hfile Store file analyzer"
+ echo " sft Store file tracker viewer"
Review Comment:
What about the hbase.cmd for windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4673: HBASE-27265 : Tool to read StoreFileTrackerFile
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on PR #4673:
URL: https://github.com/apache/hbase/pull/4673#issuecomment-1205867178
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 11s | master passed |
| +1 :green_heart: | compile | 1m 25s | master passed |
| +1 :green_heart: | shadedjars | 3m 56s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 40s | master passed |
| -0 :warning: | patch | 5m 47s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 1m 26s | the patch passed |
| +1 :green_heart: | javac | 1m 26s | the patch passed |
| +1 :green_heart: | shadedjars | 3m 58s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 39s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 388m 13s | root in the patch passed. |
| | | 410m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4673 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d2636506a87f 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 2ac5578730 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/testReport/ |
| Max. process+thread count | 4850 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4673/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org