[GitHub] [guacamole-server] mike-jumper opened a new pull request #332: GUACAMOLE-1174: Correct handling of truncated parameters when appending to URLs.

[GitBox <gi...@apache.org>]

mike-jumper opened a new pull request #332:
URL: https://github.com/apache/guacamole-server/pull/332


   The implementation of `guac_kubernetes_append_endpoint_param()` added via #301 does not correctly handle detection of truncation when appending a parameter to a URL. The previous implementation passed `length - str_len` to `snprintf()`, yet compared the return value to `length`. This is incorrect, as `length` is not the buffer size provided to `snprintf()`.
   
   This change:
   
   * Corrects the logic within `guac_kubernetes_append_endpoint_param()` such that truncation is correctly detected.
   * Adds unit tests for the URL utility functions to verify correct behavior.
   * Clarifies the documented behavior of `guac_kubernetes_append_endpoint_param()` a bit further.
   
   The new unit tests fail without the correction to the `guac_kubernetes_append_endpoint_param()` logic, which has been kept in a separate commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] necouchman merged pull request #332: GUACAMOLE-1174: Correct handling of truncated parameters when appending to URLs.

[GitBox <gi...@apache.org>]

necouchman merged pull request #332:
URL: https://github.com/apache/guacamole-server/pull/332


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org