You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/08/20 21:30:09 UTC

[kudu-CR] Bump Hive version, strip apache prefix from package 

Hello Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11277

to review the following change.


Change subject: Bump Hive version, strip apache prefix from package
......................................................................

Bump Hive version, strip apache prefix from package

This commit bumps the Hive version in thirdparty, and strips the
'apache' prefix from the thirdparty tarball package, which brings it
inline with the hadoop package naming.

Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
---
M build-support/run_dist_test.py
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 13 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/11277/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................

Bump Hive version, normalize hive package name

This commit bumps the Hive version in thirdparty, and strips the
'apache' prefix and 'bin' suffix from the thirdparty tarball package,
which brings it inline with the hadoop package naming.

Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Reviewed-on: http://gerrit.cloudera.org:8080/11277
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M build-support/run_dist_test.py
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Hao Hao: Looks good to me, approved
  Dan Burkert: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11277

to look at the new patch set (#3).

Change subject: Bump Hive version, normalize hive package name
......................................................................

Bump Hive version, normalize hive package name

This commit bumps the Hive version in thirdparty, and strips the
'apache' prefix and 'bin' suffix from the thirdparty tarball package,
which brings it inline with the hadoop package naming.

Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
---
M build-support/run_dist_test.py
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/11277/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4: Verified+1

flakes


-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 20:18:43 +0000
Gerrit-HasComments: No

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh@37
PS3, Line 37: wget https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz
I left this feedback in Hao's patch too, so it may not apply here, but could we use curl here instead, to be more consistent with the rest of the thirdparty scripts?



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 04:16:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, strip apache prefix from package

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, strip apache prefix from package
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: -bin
> Hao, would that cause issues with the other packaging issues you are dealin
Yeah, I think we need to remove -bin here as Adar suggested, otherwise it would cause issues. Sorry that I forgot to mention it when we discussed.



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 22:43:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh@52
PS4, Line 52: hive-$VERSION
> Why not use $HIVE_NAME here?
Not sure I understand, where is $HIVE_NAME defined?



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:17:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11277/3/thirdparty/package-hive.sh@37
PS3, Line 37: curl --retry 3 -L -O https://archive.apache.org/dist/hive/hive-$VERSION/$ARTIFACT.tar.gz
> I left this feedback in Hao's patch too, so it may not apply here, but coul
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 17:15:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11277

to look at the new patch set (#4).

Change subject: Bump Hive version, normalize hive package name
......................................................................

Bump Hive version, normalize hive package name

This commit bumps the Hive version in thirdparty, and strips the
'apache' prefix and 'bin' suffix from the thirdparty tarball package,
which brings it inline with the hadoop package naming.

Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
---
M build-support/run_dist_test.py
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/11277/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Bump Hive version, strip apache prefix from package

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, strip apache prefix from package
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: -bin
> Yeah, I think we need to remove -bin here as Adar suggested, otherwise it w
no problem, will update shortly.



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 23:13:09 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, strip apache prefix from package

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, strip apache prefix from package
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: -bin
Can we drop that suffix for even more consistency?


http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh@211
PS2, Line 211: # TODO(dan): bump to a release version once HIVE-17747 and HIVE-16886/HIVE-18526
             : # are published. The SHA below is the current head of branch-2.
I take it this is still at large?



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 21:33:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: "))[
> no problem, will update shortly.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 01:09:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, strip apache prefix from package

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11277

to look at the new patch set (#2).

Change subject: Bump Hive version, strip apache prefix from package
......................................................................

Bump Hive version, strip apache prefix from package

This commit bumps the Hive version in thirdparty, and strips the
'apache' prefix from the thirdparty tarball package, which brings it
inline with the hadoop package naming.

Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
---
M build-support/run_dist_test.py
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 13 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/11277/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh@52
PS4, Line 52: hive-$VERSION
> Not sure I understand, where is $HIVE_NAME defined?
Sorry, please ignore this comment. I was confusing this with other third-party downloading and building scripts.



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:32:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed a vote on this change.

Change subject: Bump Hive version, normalize hive package name
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh
File thirdparty/package-hive.sh:

http://gerrit.cloudera.org:8080/#/c/11277/4/thirdparty/package-hive.sh@52
PS4, Line 52: hive-$VERSION
Why not use $HIVE_NAME here?



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:14:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] Bump Hive version, normalize hive package name

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, normalize hive package name
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 18:24:55 +0000
Gerrit-HasComments: No

[kudu-CR] Bump Hive version, strip apache prefix from package

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11277 )

Change subject: Bump Hive version, strip apache prefix from package
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:

http://gerrit.cloudera.org:8080/#/c/11277/2/build-support/run_dist_test.py@141
PS2, Line 141: -bin
> Can we drop that suffix for even more consistency?
Hao, would that cause issues with the other packaging issues you are dealing with?


http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/11277/2/thirdparty/vars.sh@211
PS2, Line 211: # TODO(dan): bump to a release version once HIVE-17747 and HIVE-16886/HIVE-18526
             : # are published. The SHA below is the current head of branch-2.
> I take it this is still at large?
Yes, the comment is still correct.



-- 
To view, visit http://gerrit.cloudera.org:8080/11277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf6696e2a49986aba025f13653dc549e6fc5beb
Gerrit-Change-Number: 11277
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 22:20:58 +0000
Gerrit-HasComments: Yes